Skip to content

chore: added 'make build' and fixed gradle warning - #284

Merged
ewanharris merged 2 commits into
mainfrom
chore/added-make-build
Feb 12, 2026
Merged

chore: added 'make build' and fixed gradle warning#284
ewanharris merged 2 commits into
mainfrom
chore/added-make-build

Conversation

@aaguiarz

@aaguiarzaaguiarz commented Feb 11, 2026

Copy link
Copy Markdown
Member

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Enhanced build tooling by introducing a new build target and documentation.
    • Refined code quality configuration settings for improved consistency.

@aaguiarz
aaguiarz requested a review from a team as a code ownerFebruary 11, 2026 23:12
CopilotAI review requested due to automatic review settings February 11, 2026 23:12
@dosubot

dosubotBot commented Feb 11, 2026

Copy link
Copy Markdown

Related Documentation

Checked 8 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?Join Discord

@coderabbitai

coderabbitaiBot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR adds a new build Makefile target for compiling the project while skipping tests and checks, and updates the Spotless Gradle configuration to use explicit assignment syntax instead of flag-style binding.

Changes

Cohort / File(s)Summary
Makefile Build Target
Makefile
Added new build target with recipe ./gradlew build -x test -x check, updated .PHONY declaration, and added corresponding help text documentation.
Gradle Configuration
build.gradle
Updated Spotless enforceCheck property from flag-style binding to explicit assignment syntax (enforceCheck = false).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • SoulPancake
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the two main changes: adding a 'make build' target to the Makefile and fixing a Gradle warning in build.gradle.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/added-make-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented Feb 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.70%. Comparing base (c0cbc6a) to head (20885b8).

❌ Your project status has failed because the head coverage (37.70%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@## main #284 +/- ##
=========================================
Coverage 37.70% 37.70% Complexity 1236 1236 =========================================
Files 197 197 Lines 7609 7609 Branches 880 880 =========================================
Hits 2869 2869 Misses 4601 4601 Partials 139 139 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s developer workflow by adding a make build target and adjusting the Spotless Gradle configuration to address a Gradle warning.

Changes:

  • Fix Spotless enforceCheck configuration syntax in build.gradle.
  • Add a build target to the Makefile and expose it via make help.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

FileDescription
build.gradleUpdates Spotless configuration syntax (enforceCheck) to resolve a Gradle warning.
MakefileAdds make build and updates the help output and phony target list accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadMakefile Outdated
Comment threadMakefile Outdated
Comment threadMakefile Outdated
@ewanharris
ewanharris added this pull request to the merge queueFeb 12, 2026
Merged via the queue into main with commit b7e1cdbFeb 12, 2026
22 checks passed
@ewanharris
ewanharris deleted the chore/added-make-build branch February 12, 2026 15:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aaguiarz@codecov-commenter@ewanharris