Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 25
feat: oauth2 scopes for authentication#326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fc61d4a
feat: oauth2 scopes for authn
SoulPancake a576aa4
fix: readme
SoulPancake 56d908b
feat: apply suggestions for url
SoulPancake a1b2f88
feat: address comments
SoulPancake 4bf791a
fix: update README.md
SoulPancake a58e199
Merge branch 'main' into feat/oauth2-scopes
SoulPancake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6 src/main/java/dev/openfga/sdk/api/configuration/ClientCredentials.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53 src/test/java/dev/openfga/sdk/api/configuration/ClientCredentialsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -80,4 +80,57 @@ public void assertValid_invalidApiTokenIssuer() { | ||
| "Required parameter apiTokenIssuer was invalid when calling ClientCredentials.", | ||
| exception.getMessage())); | ||
| } | ||
| @Test | ||
| public void assertValid_withoutApiAudience() throws FgaInvalidParameterException { | ||
| // audience is optional for standard OAuth2 servers | ||
| ClientCredentials creds = new ClientCredentials() | ||
| .clientId(VALID_CLIENT_ID) | ||
| .clientSecret(VALID_CLIENT_SECRET) | ||
| .apiTokenIssuer(VALID_API_TOKEN_ISSUER); | ||
| // Should not throw | ||
| creds.assertValid(); | ||
| assertNull(creds.getApiAudience()); | ||
| } | ||
| @Test | ||
| public void assertValid_withScopes() throws FgaInvalidParameterException { | ||
| ClientCredentials creds = new ClientCredentials() | ||
| .clientId(VALID_CLIENT_ID) | ||
| .clientSecret(VALID_CLIENT_SECRET) | ||
| .apiTokenIssuer(VALID_API_TOKEN_ISSUER) | ||
| .scopes("read write"); | ||
| creds.assertValid(); | ||
| assertEquals("read write", creds.getScopes()); | ||
| } | ||
SoulPancake marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| @Test | ||
| public void assertValid_blankApiAudienceNormalizedToNull() throws FgaInvalidParameterException { | ||
| for (String blank : Arrays.asList("", " ", "\t\r\n")) { | ||
| ClientCredentials creds = new ClientCredentials() | ||
| .clientId(VALID_CLIENT_ID) | ||
| .clientSecret(VALID_CLIENT_SECRET) | ||
| .apiTokenIssuer(VALID_API_TOKEN_ISSUER) | ||
| .apiAudience(blank); | ||
| creds.assertValid(); | ||
| assertNull(creds.getApiAudience(), "Blank apiAudience should be normalized to null"); | ||
| } | ||
| } | ||
| @Test | ||
| public void assertValid_blankScopesNormalizedToNull() throws FgaInvalidParameterException { | ||
| for (String blank : Arrays.asList("", " ", "\t\r\n")) { | ||
| ClientCredentials creds = new ClientCredentials() | ||
| .clientId(VALID_CLIENT_ID) | ||
| .clientSecret(VALID_CLIENT_SECRET) | ||
| .apiTokenIssuer(VALID_API_TOKEN_ISSUER) | ||
| .scopes(blank); | ||
| creds.assertValid(); | ||
| assertNull(creds.getScopes(), "Blank scopes should be normalized to null"); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.