Uh oh!
There was an error while loading. Please reload this page.
chore: skip github release and use gpg signed tag flow - #347
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (38.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@## main #347 +/- ##
============================================
+ Coverage 38.47% 38.48% +0.01% - Complexity 1267 1268 +1
============================================
Files 198 198 Lines 7704 7704 Branches 900 900 ============================================
+ Hits 2964 2965 +1
Misses 4591 4591 + Partials 149 148 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR centralizes GitHub Actions workflow references from ChangesWorkflow Centralization and Release Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Switches release-please configuration to skip GitHub release creation, in favor of a GPG-signed tag flow.
Changes:
- Remove
draft: trueandforce-tag-creation: truefrom release-please config - Add
skip-github-release: trueto release-please config
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/main.yaml:
- Line 157: The reusable workflow reference for the undraft-release job
currently uses the mutable ref
"openfga/.github/.github/workflows/undraft-release.yml@main"; replace that with
a pinned full-length commit SHA (e.g.,
openfga/.github/.github/workflows/undraft-release.yml@<full-commit-sha>) to make
the job deterministic. Locate the undraft-release job in main.yaml and update
the uses string to reference the exact commit SHA (you can obtain it with git
rev-parse or from the GitHub commit history for the openfga/.github repo) so the
action no longer tracks the moving main branch.
In @.github/workflows/pr-title-check.yml:
- Line 16: Replace the external reusable workflow references that use a mutable
branch with immutable commit SHAs: locate the `uses:
openfga/.github/.github/workflows/pr-title-check.yml@main` entry in
.github/workflows/pr-title-check.yml and replace `@main` with the specific
commit SHA from the openfga/.github repo; do the same for the `uses:
.../release-please.yml@main` reference (in .github/workflows/release-please.yml)
and the `uses: .../undraft-release.yml@main` reference (in
.github/workflows/main.yaml) so each `uses:` points to an exact commit SHA
instead of `@main`.
In @.github/workflows/release-please.yml:
- Line 39: The workflow is calling the reusable workflow with "uses:
openfga/.github/.github/workflows/release-please.yml@main" while passing
release/signing secrets (RELEASER_APP_CLIENT_ID, RELEASER_APP_PRIVATE_KEY,
GPG_PRIVATE_KEY, GPG_PASSPHRASE); replace the `@main` ref with an immutable commit
SHA for the reusable workflow (i.e., change "uses:
openfga/.github/.github/workflows/release-please.yml@main" to "uses:
openfga/.github/.github/workflows/release-please.yml@<commit-sha>") so upstream
changes cannot affect future releases, using the specific SHA from the upstream
repo's commit that you want to pin.
In `@release-please-config.json`:
- Line 5: The workflow runs an undraft-release step even though release-please
is configured with "skip-github-release": true in release-please-config.json, so
update the .github/workflows/main.yaml to stop depending on a release object:
either remove the undraft-release step or add a conditional guard (e.g., check
the release-please flag or an output/variable that indicates a release was
created) so undraft-release only runs when a release was actually created;
reference the release-please-config.json "skip-github-release" key and the
undraft-release step in main.yaml when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1533f485-05c0-42f5-845a-0f36efdcfdb6
📒 Files selected for processing (4)
.github/workflows/main.yaml.github/workflows/pr-title-check.yml.github/workflows/release-please.ymlrelease-please-config.json
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Pull request was closed
Uh oh!
There was an error while loading. Please reload this page.
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit