Skip to content

fix(telemetry): fixes for telemetry attributes and metrics tracking - #176

Closed
evansims wants to merge 1 commit into
mainfrom
fix/telemetry-attributes-and-metrics-tracking
Closed

fix(telemetry): fixes for telemetry attributes and metrics tracking#176
evansims wants to merge 1 commit into
mainfrom
fix/telemetry-attributes-and-metrics-tracking

Conversation

@evansims

Copy link
Copy Markdown
Contributor

Description

  • Improved client request duration handling.
  • Fixed attribute filtering issue in some configurations.
  • Updated ClientConfiguration to include telemetry configuration (like Configuration.)
  • Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansimsevansims added the bug Something isn't working label Mar 25, 2025
@linux-foundation-easycla

linux-foundation-easyclaBot commented Mar 25, 2025

Copy link
Copy Markdown

CLA Missing IDCLA Not Signed

@codecov-commenter

codecov-commenter commented Mar 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (cefa972) to head (e9142ba).
⚠️ Report is 62 commits behind head on main.

❌ Your project status has failed because the head coverage (70.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@## main #176 +/- ##
==========================================
+ Coverage 70.37% 70.42% +0.05% 
==========================================
Files 134 134 Lines 10792 10798 +6 ==========================================
+ Hits 7595 7605 +10 + Misses 3197 3193 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evansimsevansims reopened this Mar 25, 2025
- Improved client request duration handling.
- Fixed attribute filtering issue in some configurations.
- Updated `ClientConfiguration` to include telemetry configuration (like `Configuration`.)
- Enhanced tests to validate new telemetry attributes and ensure correct duration calculations.
@evansims
evansimsforce-pushed the fix/telemetry-attributes-and-metrics-tracking branch from e97092c to e9142baCompareMarch 25, 2025 06:09
@evansims
evansims deleted the fix/telemetry-attributes-and-metrics-tracking branch March 25, 2025 06:31
@rhamzehrhamzeh mentioned this pull request Apr 30, 2025
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@evansims@codecov-commenter