Uh oh!
There was an error while loading. Please reload this page.
camera: parse uint8 regex with SafeStoi instead of stoi - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
OpenHarmonySCM-noreplyforce-pushed
the
master
branch
from
August 28, 2026 06:08
7c3dd7c to
becdde6Comparetonycoder-hubforce-pushed
the
cursor/fix-uint8-regex-stoi-safestoi
branch
from
August 28, 2026 06:24
0b66f44 to
becdde6CompareOpenHarmonySCM-noreplyforce-pushed
the
master
branch
from
August 28, 2026 23:14
becdde6 to
7c3dd7cCompareIsUint8Regex already validates integer shape via isIntegerRegex, but std::stoi can still abort on out-of-range digit strings. Reuse SafeStoi (from_chars) so overflow returns false instead of terminating. Signed-off-by: Tony Coder <407243179@qq.com>
tonycoder-hubforce-pushed
the
cursor/fix-uint8-regex-stoi-safestoi
branch
from
August 31, 2026 00:35
26e973b to
b26b285Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsUint8RegexusedisIntegerRegexthenstd::stoi. Digit-only overflow still throws.Reuse the existing
SafeStoifrom_charshelper in the same file.Test plan
Signed-off-by: Tony Coder 407243179@qq.com