Skip to content

Hotfix/94 - #143

Closed
mfeltmann wants to merge 11 commits into
openid:masterfrom
mfeltmann:hotfix/94
Closed

Hotfix/94#143
mfeltmann wants to merge 11 commits into
openid:masterfrom
mfeltmann:hotfix/94

Conversation

@mfeltmann

@mfeltmannmfeltmann commented Jan 11, 2017

Copy link
Copy Markdown

Fixes the issue that throws an IOException even when response body exists.
Important vor invalid_grant errors responded by the server.


This change is Reviewable

@codecov-io

codecov-io commented Jan 11, 2017

Copy link
Copy Markdown

Current coverage is 79.76% (diff: 100%)

Merging #143 into master will decrease coverage by 3.05%

@@ master #143 diff @@
==========================================
Files 41 41 Lines 2131 2150 +19 Methods 0 0 Messages 0 0 Branches 260 262 +2 ==========================================
- Hits 1765 1715 -50 + Misses 366 356 -10 - Partials 0 79 +79 

Powered by Codecov. Last update 022471d...6bf6dde

@mattinger

Copy link
Copy Markdown

This looks reasonable, but you'll need to add tests for this, otherwise, the code coverage checks will fail.

@iainmcgin

Copy link
Copy Markdown
Member

I believe this was superceded by #144 - if there are still outstanding changes you'd like to integrate, reopen and let me know.

@mfeltmann
mfeltmann deleted the hotfix/94 branch March 16, 2017 17:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mfeltmann@codecov-io@mattinger@iainmcgin