Skip to content

Add ability to skip issuer https check and token nonce verification - #662

Merged
agologan merged 2 commits into
masterfrom
skip-https-nonce-validation
Mar 3, 2021
Merged

Add ability to skip issuer https check and token nonce verification#662
agologan merged 2 commits into
masterfrom
skip-https-nonce-validation

Conversation

@agologan

Copy link
Copy Markdown
Collaborator

Checklist

  • I read the Contribution Guidelines
  • I signed the CLA and WG Agreements
  • I ran, updated and added unit tests as necessary.
  • I verified the contribution matches existing coding style.
  • I updated the documentation if necessary.

Motivation and Context

Change aims to address issue in #655, #585 and #657 by adding the ability to disable certain steps in ID Token validation.

@agologan
agologanforce-pushed the skip-https-nonce-validation branch from c51c016 to c6e32b0CompareMarch 2, 2021 07:42
@agologanagologan changed the title Add ability to skip iss https and token nonce validationAdd ability to skip issuer https check and token nonce verificationMar 2, 2021
@carstenhag

Copy link
Copy Markdown

Looks fitting for my use case (#655), thanks for adding this :)

Comment threadlibrary/java/net/openid/appauth/AppAuthConfiguration.java
Comment threadlibrary/java/net/openid/appauth/AppAuthConfiguration.java
@agologan
agologan merged commit 429b532 into masterMar 3, 2021
@agologan
agologan deleted the skip-https-nonce-validation branch March 3, 2021 19:04
@carstenhag

Copy link
Copy Markdown

Looks good, thanks! :)

@cumcum8197

Copy link
Copy Markdown

429b532

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@agologan@carstenhag@cumcum8197