Skip to content

Extend level scattering to support incident photons - #3675

Open
GuySten wants to merge 23 commits into
openmc-dev:developfrom
GuySten:level-inelastic
Open

Extend level scattering to support incident photons#3675
GuySten wants to merge 23 commits into
openmc-dev:developfrom
GuySten:level-inelastic

Conversation

@GuySten

@GuyStenGuySten commented Dec 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR extend Level Scattering to support incident photons.
This is a small step in implementing photonuclear physics.

A roadmap for the photonuclear physics feature can be found here #1941.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuyStenGuySten changed the title extend level scattering to support incident photonExtend level scattering to support incident photonsDec 9, 2025
@GuySten
GuySten marked this pull request as ready for review December 9, 2025 23:55
paulromano
paulromano requested changes Dec 12, 2025
View reviewed changes

@paulromanopaulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuySten Thanks for starting with a small PR to get us toward support for photonuclear physics. This PR just needs some documentation but otherwise it looks good to me.

Comment threadsrc/distribution_energy.cpp
Comment threadinclude/openmc/distribution_energy.h Outdated
@GuySten

GuySten commented Dec 30, 2025

Copy link
Copy Markdown
ContributorAuthor

This PR should be ready now.

@GuyStenGuySten mentioned this pull request Feb 2, 2026
Open
@GuySten

GuySten commented Feb 2, 2026

Copy link
Copy Markdown
ContributorAuthor

@paulromano, can you take some time to finish reviewing this PR?
It should be ready to be merged.

shimwell
shimwell reviewed Aug 24, 2026
View reviewed changes
Comment threadopenmc/data/energy_distribution.py Outdated
shimwell
shimwell reviewed Aug 24, 2026
View reviewed changes
Comment threadsrc/distribution_energy.cpp Outdated
GuyStenand others added 4 commits August 24, 2026 16:47
@GuySten@shimwell
Apply suggestion from@shimwell
d355de7
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
@GuySten@shimwell
Update src/distribution_energy.cpp
2959bf9
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
@GuySten
Merge branch 'develop' into level-inelastic
92b13d9
@GuySten
update according to shimwell fix
9d195cf
@GuyStenGuySten mentioned this pull request Aug 24, 2026
Closed
5 tasks
@GuySten

GuySten commented Aug 24, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, @shimwell.
I think everything is good now.

@GuySten
GuySten requested a review from shimwellAugust 24, 2026 17:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulromanopaulromanoAwaiting requested review from paulromanopaulromano is a code owner
@shimwellshimwellAwaiting requested review from shimwell

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Photonuclear Physics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuySten@paulromano@shimwell