Implementation of surfaces with custom implicit function by pferney05 · Pull Request #4010 · openmc-dev/openmc

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

pferney05 · 2026-07-10T23:53:23Z

Description

This pull request adds support for function-based implicit surfaces in OpenMC. It introduces a user-facing expression-tree interface for defining arbitrary 3D implicit functions, creates OpenMC surface objects from those functions, and enables them to be combined with standard regions through the existing Boolean geometry interface.

The implementation includes:

A new openmc.implicit expression system for composing elementary symbols and operators into implicit functions.
A new ImplicitSurface surface type with configurable isovalue support.
Translation and rotation support through surface parameters.
A Cached expression node that avoids redundant sub-expression evaluations during function evaluation.
A legacy TPMS interface for pitch/isovalue-based definitions to ease migration from the previous TPMS implementation.
Two interval-analysis ray-tracing solvers for finding the first positive root of a continuous Lipschitz function along a particle ray: a reference naive Lipschitz solver and a faster stack-based Lipschitz solver.
User-adjustable solver parameters for absolute root tolerance, function tolerance, maximum iteration count, and crossing margin.

The motivation is to make OpenMC more robust and versatile for geometries that are difficult or inefficient to represent with constructive solid geometry primitives or triangular meshes, especially triply periodic minimal surface (TPMS) fuel concepts and graded TPMS lattices. Unlike standard quadrics, these surfaces generally do not have analytic ray-surface intersections, so the implementation uses numerical root finding along the ray.

The implementation was validated on eight calculations spanning seven geometries: a reference sphere, Primitive TPMS, Gyroid TPMS, Diamond TPMS, a strongly pitch-graded Primitive TPMS, a Squircle surface, and a Squared Circle surface. The implicit-surface sphere reproduces the standard OpenMC sphere result within statistical uncertainty, and the default solver parameters were found to give consistent results across all validation cases.

@sallustius @gridley @paulromano @ChasingNeutrons @shimwell You may be interested in this. This is a big PR which generalises #3292 to a wide range of functions.

Fixes # (issue)
N/A

Checklist

I have performed a self-review of my own code
I have run clang-format (version 18) on any C++ source files (if applicable)
I have followed the style guidelines for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)

…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

…and implicit

…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

…oint, README.md notes for future improvement

RokShox · 2026-07-27T04:34:14Z

In openmc/surface.py at lines 2872 and 2926, the def for this class method is duplicated

@classmethod
def from_pitch_isovalue(cls, tpms: str, pitch: float, isovalue: float, **kwargs) -> 'TPMS':

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

paul-ferney added 23 commits May 20, 2026 16:51

First commit
da5d9da

ImplicitSurface, TPMS and ImplicitFunction implementation.
feeafe4

Removed dead code in rmul.\nAdd docstring to Cached to document corre…
9b1fdba
…ct use.\nAdd a cache checker to warn for unused cached functions.\nAdd a test for wrong xml tag import.

*** Major commit Implicit Functions
74e5281

Added implicit settings
edca619

Added regression tests and completed unit tests on settings, surface …
59185a5
…and implicit

Cache: lazy gradient to avoid solid ray plot error. Settings: check i…
ff79bd6
…mplicit solver name is valid. changed max_iter to maxiter to get the same var name everywhere. Cell: check if in cell before throwing fatal error to avoid error in solid ray plot.

Update sphere classic (no need implicit solver settings)
8fe28cc

Update new regression tests for more diversified functions
9ca5936

Added Min Max nodes
82cb717

Wrote documentation.
99793b9

Updated Cache to improve performance.
0ae47fc

Added relevant include to implicit.h for compiuler robustness.
3217c11

fixed redudndant surface issue
6f4c9cd

***Last commit v1, test update, surface compatibility with array of p…
e298127
…oint, README.md notes for future improvement

Merge branch 'develop' into ImplicitFunction
d92d2c3

Update solver parameter
4b77cba

add clang-format to install README
bbc6353

change install instructions to README
1dd9fda

manual clang-format on src
d9f382d

Updated test and README.md to pass CI tests
9986a12

Renamed regression tests for more clarity
2fa1976

updated Diamond Test to match paper example
6125408

shimwell mentioned this pull request Jul 27, 2026
Apply virtual material densities to microscopic tally results #4029
Merged
5 tasks

Removed redundant lines in TPMS helper class
724039f

Uh oh!

Conversation

pferney05 commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

RokShox commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pferney05 commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

RokShox commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pferney05 commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

RokShox commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pferney05 commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

RokShox commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

pferney05 commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

RokShox commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading

pferney05 commented Jul 10, 2026•
edited
Loading

RokShox commented Jul 27, 2026•
edited
Loading