Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
j-fletcher wants to merge 13 commits into
base:develop
Choose a base branch
from
Draft

Angular flux tallying capabilities for Random Ray #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fa3fc91
angular flux init
j-fletcher Jun 16, 2026
6d4650c
Merge branch 'develop' into rr_angular
j-fletcher Aug 6, 2026
8ff54d8
Particle, RandomRay, SourceRegion and TallyTask changes to support an…
j-fletcher Aug 13, 2026
a7d5970
Merge branch 'develop' into rr_angular
j-fletcher Aug 13, 2026
eae7736
angular flux tallying workflow init
j-fletcher Aug 21, 2026
566415f
Add pointset generators
j-fletcher Aug 21, 2026
f823358
remove mesh data field
j-fletcher Aug 25, 2026
2cdebea
Compact data format for angular_flux_new, angular quadrature storage
j-fletcher Aug 26, 2026
afce8f4
formatting and MeshAngularFilter in Python API
j-fletcher Aug 26, 2026
4728328
MeshAngularFilter in lib, updating angular flux accumulation flag
j-fletcher Aug 27, 2026
e1c866f
fix cpp syntax
j-fletcher Aug 27, 2026
3f8ca2b
MeshAngularFilter bugfixes
j-fletcher Aug 27, 2026
101fa8f
angular_pointset typename consistency
j-fletcher Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
src/tallies/filter_material.cpp
src/tallies/filter_materialfrom.cpp
src/tallies/filter_mesh.cpp
src/tallies/filter_meshangular.cpp
src/tallies/filter_meshborn.cpp
src/tallies/filter_meshmaterial.cpp
src/tallies/filter_meshsurface.cpp
Expand Down
2 changes: 2 additions & 0 deletions include/openmc/capi.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down
86 changes: 84 additions & 2 deletions include/openmc/mesh.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
//! element
//! \param[inout] materials Array storing material indices
//! \param[inout] volumes Array storing volumes
void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
int32_t* materials, double* volumes) const;

//! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
//! \param[inout] materials Array storing material indices
//! \param[inout] volumes Array storing volumes
//! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
int32_t* materials, double* volumes, double* bboxes) const;

//! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
AngularMesh() { n_dimension_ = 2; }
AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

// Angular meshes partition direction space, not a volume.
// Therefore, "bin crossing" methods are not used; only the "get_bin" method.
void bins_crossed(Position r0, Position r1, const Direction& u,
vector<int>& bins, vector<double>& lengths) const override
{
fatal_error("Angular meshes do not support spatial tracklength tallies.");
}

void surface_bins_crossed(Position r0, Position r1, const Direction& u,
vector<int>& bins) const override
{
fatal_error("Angular meshes do not support surface-crossing tallies.");
}

int n_surface_bins() const override { return 0; }

std::pair<vector<double>, vector<double>> plot(
Position plot_ll, Position plot_ur) const override
{
return {{}, {}};
}

void material_volumes(int nx, int ny, int nz, int max_materials,
int32_t* materials, double* volumes) const override
{
fatal_error("material_volumes() is not supported for angular meshes");
}

void material_volumes(int nx, int ny, int nz, int max_materials,
int32_t* materials, double* volumes, double* bboxes) const override
{
fatal_error("material_volumes() is not supported for angular meshes");
}

std::string bin_label(int bin) const override
{
return fmt::format("Element Index ({})", bin);
}

Position lower_left() const override { return {-1., -1., -1.}; }
Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
UnitSpherePointset() = default;
explicit UnitSpherePointset(vector<Direction> points);
UnitSpherePointset(pugi::xml_node node);
UnitSpherePointset(hid_t group);

//! TODO: add sampling from within a spherical Voronoi cell
Position sample_element(int32_t bin, uint64_t* seed) const override
{
fatal_error(
"Sampling over a UnitSpherePointset angular mesh is not supported");
}

int get_bin(Direction u) const override;

int n_bins() const override { return static_cast<int>(points_.size()); }

double volume(int bin) const override
{
fatal_error("Volume calculation over UnitSpherePointset is not supported");
}

std::string get_mesh_type() const override { return mesh_type; }
static const std::string mesh_type;

void to_hdf5_inner(hid_t group) const override;

vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down
4 changes: 4 additions & 0 deletions include/openmc/particle.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
void cross_periodic_bc(
const Surface& surf, Position new_r, Direction new_u, int new_surface);

//! Reset angular flux tally bin if in RandomRay mode
//! (does nothing for MC particles)
virtual void direction_changed() {}

//! mark a particle as lost and create a particle restart file
//! \param message A warning message to display
virtual void mark_as_lost(const char* message) override;
Expand Down
18 changes: 16 additions & 2 deletions include/openmc/random_ray/flat_source_domain.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
virtual void update_single_neutron_source(SourceRegionHandle& srh);
virtual void update_all_neutron_sources();
void compute_k_eff();
virtual void normalize_scalar_flux_and_volumes(
virtual void normalize_flux_and_volumes(
double total_active_distance_per_iteration);

int64_t add_source_to_scalar_flux();
virtual void batch_reset();
void convert_source_regions_to_tallies(int64_t start_sr_id);
void initialize_angular_quadrature();
void reset_tally_volumes();
void random_ray_tally();
virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
int64_t lookup_mesh_bin(int64_t sr, Position r) const;
int lookup_mesh_idx(int64_t sr) const;
int lookup_angular_bin(Direction u) const;
Direction angular_quadrature_direction(int a) const;
bool tally_angular_flux_applies(
int cell_idx, int material, int mesh_idx) const;

//----------------------------------------------------------------------------
// Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

//----------------------------------------------------------------------------
// Private data members
int negroups_; // Number of energy groups in simulation
int negroups_; // Number of energy groups in simulation
int nangles_ {1}; // Number of bins for any angular flux tallies
const UnitSpherePointset* angular_mesh_ {nullptr};

vector<bool> tally_is_angular_;
std::unordered_set<int32_t> angular_target_cells_;
std::unordered_set<int32_t> angular_target_materials_;
std::unordered_set<int32_t> angular_target_meshes_;
bool tally_angular_flux_everywhere_ {false};

double
simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down
2 changes: 1 addition & 1 deletion include/openmc/random_ray/linear_source_domain.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
//----------------------------------------------------------------------------
// Methods
void update_single_neutron_source(SourceRegionHandle& srh) override;
void normalize_scalar_flux_and_volumes(
void normalize_flux_and_volumes(
double total_active_distance_per_iteration) override;

void batch_reset() override;
Expand Down
3 changes: 3 additions & 0 deletions include/openmc/random_ray/random_ray.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
SourceRegionHandle& srh, double distance, bool is_active, Position r);
void attenuate_flux_linear_source_void(
SourceRegionHandle& srh, double distance, bool is_active, Position r);
void direction_changed() override { angular_bin_ = C_NONE; }

void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
uint64_t transport_history_based_single_ray();
SourceSite sample_prng();
SourceSite sample_halton();
SourceSite sample_s2();
int angular_bin(); // accessor for current angular quadrature bin index

//----------------------------------------------------------------------------
// Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

int negroups_;
int ntemperature_;
int angular_bin_ {C_NONE};
FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
// data needed for ray transport
double distance_travelled_ {0};
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Angular flux tallying capabilities for Random Ray#4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Draft

j-fletcher
wants to merge
13
commits into

base:develop
Choose a base branch

from

 Draft


Angular flux tallying capabilities for Random Ray
#4072
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
fa3fc91

angular flux init


j-fletcher Jun 16, 2026
6d4650c

Merge branch 'develop' into rr_angular


j-fletcher Aug 6, 2026
8ff54d8

Particle, RandomRay, SourceRegion and TallyTask changes to support an…


j-fletcher Aug 13, 2026
a7d5970

Merge branch 'develop' into rr_angular


j-fletcher Aug 13, 2026
eae7736

angular flux tallying workflow init


j-fletcher Aug 21, 2026
566415f

Add pointset generators


j-fletcher Aug 21, 2026
f823358

remove mesh data field


j-fletcher Aug 25, 2026
2cdebea

Compact data format for angular_flux_new, angular quadrature storage


j-fletcher Aug 26, 2026
afce8f4

formatting and MeshAngularFilter in Python API


j-fletcher Aug 26, 2026
4728328

MeshAngularFilter in lib, updating angular flux accumulation flag


j-fletcher Aug 27, 2026
e1c866f

fix cpp syntax


j-fletcher Aug 27, 2026
3f8ca2b

MeshAngularFilter bugfixes


j-fletcher Aug 27, 2026
101fa8f

angular_pointset typename consistency


j-fletcher Aug 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
CMakeLists.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -461,6 +461,7 @@ list(APPEND libopenmc_SOURCES
 src/tallies/filter_material.cpp
 src/tallies/filter_materialfrom.cpp
 src/tallies/filter_mesh.cpp
 src/tallies/filter_meshangular.cpp
 src/tallies/filter_meshborn.cpp
 src/tallies/filter_meshmaterial.cpp
 src/tallies/filter_meshsurface.cpp
Expand Down

2 changes: 2 additions & 0 deletions
include/openmc/capi.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,6 +144,8 @@ int openmc_mesh_get_n_elements(int32_t index, size_t* n);
int openmc_mesh_get_volumes(int32_t index, double* volumes);
int openmc_mesh_material_volumes(int32_t index, int nx, int ny, int nz,
 int max_mats, int32_t* materials, double* volumes, double* bboxes);
int openmc_meshangular_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshangular_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_meshsurface_filter_get_mesh(int32_t index, int32_t* index_mesh);
int openmc_meshsurface_filter_set_mesh(int32_t index, int32_t index_mesh);
int openmc_new_filter(const char* type, int32_t* index);
Expand Down

86 changes: 84 additions & 2 deletions
include/openmc/mesh.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -262,7 +262,7 @@ class Mesh {
 //! element
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const;

 //! Determine volume and bounding boxes of materials within each mesh element
Expand All@@ -275,7 +275,7 @@ class Mesh {
 //! \param[inout] materials Array storing material indices
 //! \param[inout] volumes Array storing volumes
 //! \param[inout] bboxes Array storing bounding boxes (n_elems, table_size, 6)
 void material_volumes(int nx, int ny, int nz, int max_materials,
virtual void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const;

 //! Determine bounding box of mesh
Expand DownExpand Up@@ -826,6 +826,88 @@ class UnstructuredMesh : public Mesh {
 virtual void initialize() = 0;
};

// Abstract class for meshes over directions (points on the unit sphere),
// as opposed to meshes over volumes.
class AngularMesh : public Mesh {
public:
 AngularMesh() { n_dimension_ = 2; }
 AngularMesh(pugi::xml_node node) : Mesh(node) { n_dimension_ = 2; }
 AngularMesh(hid_t group) : Mesh(group) { n_dimension_ = 2; }

 // Angular meshes partition direction space, not a volume.
 // Therefore, "bin crossing" methods are not used; only the "get_bin" method.
 void bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins, vector<double>& lengths) const override
 {
 fatal_error("Angular meshes do not support spatial tracklength tallies.");
 }

 void surface_bins_crossed(Position r0, Position r1, const Direction& u,
 vector<int>& bins) const override
 {
 fatal_error("Angular meshes do not support surface-crossing tallies.");
 }

 int n_surface_bins() const override { return 0; }

 std::pair<vector<double>, vector<double>> plot(
 Position plot_ll, Position plot_ur) const override
 {
 return {{}, {}};
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 void material_volumes(int nx, int ny, int nz, int max_materials,
 int32_t* materials, double* volumes, double* bboxes) const override
 {
 fatal_error("material_volumes() is not supported for angular meshes");
 }

 std::string bin_label(int bin) const override
 {
 return fmt::format("Element Index ({})", bin);
 }

 Position lower_left() const override { return {-1., -1., -1.}; }
 Position upper_right() const override { return {1., 1., 1.}; }
};

class UnitSpherePointset : public AngularMesh {
public:
 UnitSpherePointset() = default;
 explicit UnitSpherePointset(vector<Direction> points);
 UnitSpherePointset(pugi::xml_node node);
 UnitSpherePointset(hid_t group);

 //! TODO: add sampling from within a spherical Voronoi cell
 Position sample_element(int32_t bin, uint64_t* seed) const override
 {
 fatal_error(
 "Sampling over a UnitSpherePointset angular mesh is not supported");
 }

 int get_bin(Direction u) const override;

 int n_bins() const override { return static_cast<int>(points_.size()); }

 double volume(int bin) const override
 {
 fatal_error("Volume calculation over UnitSpherePointset is not supported");
 }

 std::string get_mesh_type() const override { return mesh_type; }
 static const std::string mesh_type;

 void to_hdf5_inner(hid_t group) const override;

 vector<Position> points_;
};

#ifdef OPENMC_DAGMC_ENABLED

class MOABMesh : public UnstructuredMesh {
Expand Down

4 changes: 4 additions & 0 deletions
include/openmc/particle.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -106,6 +106,10 @@ class Particle : public ParticleData {
 void cross_periodic_bc(
 const Surface& surf, Position new_r, Direction new_u, int new_surface);

 //! Reset angular flux tally bin if in RandomRay mode
 //! (does nothing for MC particles)
 virtual void direction_changed() {}

 //! mark a particle as lost and create a particle restart file
 //! \param message A warning message to display
 virtual void mark_as_lost(const char* message) override;
Expand Down

18 changes: 16 additions & 2 deletions
include/openmc/random_ray/flat_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
#define OPENMC_RANDOM_RAY_FLAT_SOURCE_DOMAIN_H

#include "openmc/constants.h"
#include "openmc/mesh.h"
#include "openmc/openmp_interface.h"
#include "openmc/position.h"
#include "openmc/random_ray/parallel_map.h"
Expand DownExpand Up@@ -30,12 +31,13 @@ class FlatSourceDomain {
 virtual void update_single_neutron_source(SourceRegionHandle& srh);
 virtual void update_all_neutron_sources();
 void compute_k_eff();
 virtual void normalize_scalar_flux_and_volumes(
 virtual void normalize_flux_and_volumes(
 double total_active_distance_per_iteration);

 int64_t add_source_to_scalar_flux();
 virtual void batch_reset();
 void convert_source_regions_to_tallies(int64_t start_sr_id);
 void initialize_angular_quadrature();
 void reset_tally_volumes();
 void random_ray_tally();
 virtual void accumulate_iteration_flux();
Expand DownExpand Up@@ -72,6 +74,10 @@ class FlatSourceDomain {
 SourceRegionKey lookup_source_region_key(const GeometryState& p) const;
 int64_t lookup_mesh_bin(int64_t sr, Position r) const;
 int lookup_mesh_idx(int64_t sr) const;
 int lookup_angular_bin(Direction u) const;
 Direction angular_quadrature_direction(int a) const;
 bool tally_angular_flux_applies(
 int cell_idx, int material, int mesh_idx) const;

 //----------------------------------------------------------------------------
 // Static Data members
Expand DownExpand Up@@ -173,7 +179,15 @@ class FlatSourceDomain {

 //----------------------------------------------------------------------------
 // Private data members
 int negroups_; // Number of energy groups in simulation
 int negroups_; // Number of energy groups in simulation
 int nangles_ {1}; // Number of bins for any angular flux tallies
 const UnitSpherePointset* angular_mesh_ {nullptr};

 vector<bool> tally_is_angular_;
 std::unordered_set<int32_t> angular_target_cells_;
 std::unordered_set<int32_t> angular_target_materials_;
 std::unordered_set<int32_t> angular_target_meshes_;
 bool tally_angular_flux_everywhere_ {false};

 double
 simulation_volume_; // Total physical volume of the simulation domain, as
Expand Down

2 changes: 1 addition & 1 deletion
include/openmc/random_ray/linear_source_domain.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ class LinearSourceDomain : public FlatSourceDomain {
 //----------------------------------------------------------------------------
 // Methods
 void update_single_neutron_source(SourceRegionHandle& srh) override;
 void normalize_scalar_flux_and_volumes(
 void normalize_flux_and_volumes(
 double total_active_distance_per_iteration) override;

 void batch_reset() override;
Expand Down

3 changes: 3 additions & 0 deletions
include/openmc/random_ray/random_ray.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,12 +36,14 @@ class RandomRay : public Particle {
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void attenuate_flux_linear_source_void(
 SourceRegionHandle& srh, double distance, bool is_active, Position r);
 void direction_changed() override { angular_bin_ = C_NONE; }

 void initialize_ray(uint64_t ray_id, FlatSourceDomain* domain);
 uint64_t transport_history_based_single_ray();
 SourceSite sample_prng();
 SourceSite sample_halton();
 SourceSite sample_s2();
 int angular_bin(); // accessor for current angular quadrature bin index

 //----------------------------------------------------------------------------
 // Static data members
Expand All@@ -67,6 +69,7 @@ class RandomRay : public Particle {

 int negroups_;
 int ntemperature_;
 int angular_bin_ {C_NONE};
 FlatSourceDomain* domain_ {nullptr}; // pointer to domain that has flat source
 // data needed for ray transport
 double distance_travelled_ {0};
Expand Down
Loading
Loading