Uh oh!
There was an error while loading. Please reload this page.
Addition of 3 more databases - #22
Conversation
ppinard
left a comment
There was a problem hiding this comment.
Minor comments. One important thing is to run black formatting on the changes. Also, add include pyxray/data/*.txt to MANIFEST.in, so ElamDB12.txt gets pick-up in the source distribution.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ppinard
commented
Nov 22, 2020
achuda-g
commented
Nov 22, 2020
I've committed the changes. Will the pull request be automatically updated? |
ppinard
commented
Nov 22, 2020
I will wait for PR #24 to go through and then merge your PR. |
I think the fix in PR #24 was to get only distinct transitions. The test which is failing with my changes now might continue to fail for two of the cases (Z=3 and Z=6) after PR #24 . It is because Also on a side note, I calculated transition probability for |
For "chantler2005", I'm using shelldata.csv file available here https://github.com/openmicroanalysis/FFAST.jl/blob/master/data/shelldata.csv . I just figured I could stream the data directly from the website. I couldn't find a way to access the data directly from the NIST website. Should I do any changes? And should any liscensing data be included? |
ppinard
commented
Nov 26, 2020
Yes that's correct. The tests need to be updated, but at least now the values are correct. |
ppinard
commented
Nov 26, 2020
I think the transition probability should include the Coster-Kronig transitions. Is the fluorescence yield discussed in Elam (2002) reference? |
ppinard
commented
Nov 26, 2020
Have you look at this Julia script in FFAST.jl project?
There is no licence or reference document for all the databases included in pyxray, but that would be a good thing to add. Could you either add a section in the README.rst or simply add a new issue to add references at a later point? |
Thanks, I had not seen that script. I can implement something similar. |
achuda-g
commented
Dec 2, 2020
I checked the sources used by the author in Elam 2002. In all of them [1, 2, 3] Coster-Kronig yields are considered separately, i.e. fluorescence yield + Auger yield + Croster-Kronig yield = 1. Conster-Kronig yield covers both radiative and radiationless Coster-Kronig transitions. Both fluorescence and auger yields cover purely inter-shell radiative and radiationless transitions, respectively. So I think my calculation (fluorescence yield * relative intensity) must yield the radiative transition probability for inter-shell transitions correctly. [1] Krause, M.O., 1979. Atomic radiative and radiationless yields for K and L shells. J. Phys. Chem. Ref. Data 8, 307–327 |
Please let me know if I have to make any corrections or changes.