Uh oh!
There was an error while loading. Please reload this page.
Updating examples to use names instead of integer ids whenever possible - #1070
Updating examples to use names instead of integer ids whenever possible#1070ArlindKadra wants to merge 3 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| Dataset ID of the dataset to download. It can be an integer or it can be a string | ||
| of the dataset name. |
There was a problem hiding this comment.
| DatasetIDofthedatasettodownload. Itcanbeanintegeroritcanbeastring | |
| ofthedatasetname. | |
| TheIDornameofthedatasettodownload. |
Since ID's are parsed to integer anyway if they're given as strings.
There was a problem hiding this comment.
@PGijsbers I can also do that, however, I tried to keep it consistent with
openml-python/openml/datasets/functions.py
Lines 323 to 325 in 5669431
get_datasetsThere was a problem hiding this comment.
I think the difference is fine, or should favor the simpler wording.
ArlindKadra
commented
May 4, 2021
@PGijsbers@mfeurer While making the modifications I noticed a study that actually had no alias, can that be a case? |
PGijsbers
commented
May 4, 2021
An alias is not required, but I'll ask people with access if they're prepared to add one (I don't believe there's an API call for it). |
ArlindKadra
commented
May 4, 2021
Ah thanks. Yeah, then maybe it is not worth the effort. I can just keep it like that and write a comment at the tutorial like we discussed for the datasets. |
mfeurer
commented
May 6, 2021
Hey, what do you think about adding the fact that a user should always use names and version instead of the IDs when creating examples to the pull request template? (Also maybe that a warning should be emitted when using the test server, although that's not really related to this PR) |
Reference Issue
#1066, #1063
What does this PR implement/fix? Explain your changes.
get_datasetHow should this PR be tested?
Existing unit tests.