[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/psf/black: 22.6.0 → 23.3.0
• github.com/pre-commit/mirrors-mypy: v0.961 → v1.2.0
• github.com/pycqa/flake8: 4.0.1 → 6.0.0

[PGijsbers]

Note to other contributors:

LGTM except for several mypy errors that need to be fixed: https://results.pre-commit.ci/run/github/17939040/1677540245.VvURZtjgSmyCCC9kJo-7Ww

Additionally, it looks like flake8 checks for a line length of 80, while our line limit should be 100 characters.

I can't address this right away, please assign yourself or leave a message if you are working on it.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.60%. Comparing base (fb9f9eb) to head (63dc0cc).

Files with missing lines	Patch %	Lines
openml/study/study.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## develop #1223 +/- ##
===========================================
+ Coverage 85.24% 85.60% +0.36% 
===========================================
Files 38 38 Lines 5008 5009 +1 ===========================================
+ Hits 4269 4288 +19 + Misses 739 721 -18 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mfeurer]

I just had a look at what went wrong here with flake8 and must say I'm puzzled. flake8 simply ignore the .flake8 file:

(openml) feurerm@mllap04:~/sync_dir/projects/openml/python$ flake8 --filename ./openml/evaluations/evaluation.py --verbose
flake8.checker MainProcess 82 INFO Making checkers
flake8.checker MainProcess 139 INFO Checking 1 files
flake8.main.application MainProcess 153 INFO Finished running
flake8.main.application MainProcess 153 INFO Reporting errors
flake8.main.application MainProcess 154 INFO Found a total of 4 violations and reported 4
./openml/evaluations/evaluation.py:85:80: E501 line too long (80 > 79 characters)
./openml/evaluations/evaluation.py:87:80: E501 line too long (80 > 79 characters)
./openml/evaluations/evaluation.py:91:80: E501 line too long (86 > 79 characters)
./openml/evaluations/evaluation.py:114:80: E501 line too long (89 > 79 characters)

and one has to instead pass it in manually:

(openml) feurerm@mllap04:~/sync_dir/projects/openml/python$ flake8 --filename ./openml/evaluations/evaluation.py --verbose --config=.flake8
flake8.checker MainProcess 82 INFO Making checkers
flake8.checker MainProcess 133 INFO Checking 1 files
flake8.main.application MainProcess 147 INFO Finished running
flake8.main.application MainProcess 147 INFO Reporting errors
flake8.main.application MainProcess 148 INFO Found a total of 0 violations and reported 0

[mfeurer]

After looking into this a bit more, I found that this problem was introduced in PyCQA/flake8@65c8937 and that the previous commit PyCQA/flake8@00ca630 actually works. This can be tested by putting the commit hashes into the rev field of the file .pre-commit-config.yaml.

I will raise an issue with the flake8 project if someone can confirm this.

[LennartPurucker]

I will raise an issue with the flake8 project if someone can confirm this.

I was able to reproduce this issue! Using the older commit as a reference works for me.

With the changes I just pushed, all pre-commits pass:

[mfeurer]

I forgot to post the reason why this failed and what I fixed: PyCQA/flake8#1630