Skip to content

Deprecate output_format='dict' - #1258

Merged
mfeurer merged 21 commits into
developfrom
pandas_default
Jun 16, 2023
Merged

Deprecate output_format='dict'#1258
mfeurer merged 21 commits into
developfrom
pandas_default

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

Deprecates output_format='dict':

  • add a future warning with any of the list_* functions are called with output_format='dict',
  • update all internal code and examples which used to rely on the default of output_format='dict'

WIP: Going through unit tests I incidentally broke

@PGijsbers
PGijsbers requested a review from mfeurerJune 15, 2023 14:16
Comment threadopenml/datasets/functions.py Outdated
Comment threadtests/test_utils/test_utils.py
@LennartPurucker

Copy link
Copy Markdown
Contributor

Looks good to me at this point.

@codecov-commenter

codecov-commenter commented Jun 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 86.20% and project coverage change: +3.84 🎉

Comparison is base (3b3553b) 81.66% compared to head (c130c41) 85.51%.

❗ Current head c130c41 differs from pull request most recent head 22a6dd3. Consider uploading reports for the commit 22a6dd3 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## develop #1258 +/- ##
===========================================
+ Coverage 81.66% 85.51% +3.84% 
===========================================
Files 38 38 Lines 5012 5343 +331 ===========================================
+ Hits 4093 4569 +476 + Misses 919 774 -145 
Impacted FilesCoverage Δ
openml/study/functions.py85.36% <25.00%> (-5.19%)⬇️
openml/evaluations/functions.py82.35% <50.00%> (+11.04%)⬆️
openml/flows/functions.py83.97% <50.00%> (-0.77%)⬇️
openml/tasks/functions.py84.73% <75.00%> (+1.04%)⬆️
openml/datasets/dataset.py87.55% <91.07%> (+1.77%)⬆️
openml/datasets/functions.py93.01% <93.93%> (+4.76%)⬆️
openml/datasets/data_feature.py71.42% <100.00%> (+2.19%)⬆️
openml/runs/functions.py84.13% <100.00%> (+8.71%)⬆️
openml/setups/functions.py93.08% <100.00%> (+7.14%)⬆️
openml/utils.py92.21% <100.00%> (+0.34%)⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PGijsbers
PGijsbers marked this pull request as ready for review June 15, 2023 17:43
@PGijsbers

PGijsbers commented Jun 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I think I cleared up the tests I accidentally broke after refactoring, but there are a lot of failures due to the test server state (also on develop). I would prefer to wait until we have working CI again.

Comment threadtests/test_runs/test_run.py Outdated
Comment threadtests/test_tasks/test_task_methods.py Outdated
@PGijsbers

Copy link
Copy Markdown
CollaboratorAuthor

@mfeurer only test_list_all_with_multiple_batches fails now, as expected. I think we can go ahead and merge this.

@mfeurer
mfeurer merged commit 495162d into developJun 16, 2023
@mfeurer
mfeurer deleted the pandas_default branch June 16, 2023 12:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PGijsbers@LennartPurucker@codecov-commenter@mfeurer