Skip to content

Only download arff if required - #1346

Merged
PGijsbers merged 3 commits into
developfrom
lazy-arff
Sep 16, 2024
Merged

Only download arff if required#1346
PGijsbers merged 3 commits into
developfrom
lazy-arff

Conversation

@PGijsbers

@PGijsbersPGijsbers commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

Progress in #1032. I think it's mostly there but I need a little time to think it over and see how well this is covered by the test server, since there mostly are not parquet files available.

edit: added a check to an existing test which I think covers it well enough. Especially since we need to update/rewrite some of the tests with lazy loading being on by default. This I will do in a separate PR.

@codecov-commenter

codecov-commenter commented Sep 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (de983ac) to head (f41a1c6).
Report is 2 commits behind head on develop.

Files with missing linesPatch %Lines
openml/datasets/dataset.py86.36%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #1346 +/- ##
===========================================
+ Coverage 83.88% 84.19% +0.31% 
===========================================
Files 38 38 Lines 5261 5271 +10 ===========================================
+ Hits 4413 4438 +25 + Misses 848 833 -15 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PGijsbers
PGijsbers marked this pull request as ready for review September 13, 2024 12:29

@LennartPuruckerLennartPurucker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have one question.

I am unsure about the tests, but I trust that you know best how reliable they are right now.

Comment threadopenml/datasets/dataset.py
@PGijsbers
PGijsbers merged commit b4d038f into developSep 16, 2024
@PGijsbers
PGijsbers deleted the lazy-arff branch September 16, 2024 08:53
@PGijsbersPGijsbers changed the title Lazy arffOnly download arff if requiredSep 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-commenter@LennartPurucker