Skip to content

Add/1034 - #1352

Merged
PGijsbers merged 10 commits into
developfrom
add/1034
Sep 22, 2024
Merged

Add/1034#1352
PGijsbers merged 10 commits into
developfrom
add/1034

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

Turn on lazy loading by default for datasets.
Leaving tasks for a separate PR as I notice the diff is getting big since I made some additional changes to the tests.
So only progress for #1034.

I couldn't clean up everything, but I tried to clean things up a little bit.
The use of parametrize required me to work outside of the unittest class.
I tried to still make behavior similar as possible so its easier that they're not doing wildly different things (I do think that a lot of the setup/teardown that come with the general behavior isn't really needed though).

Comment threadopenml/testing.py
Comment threadtests/test_datasets/test_dataset_functions.py
Comment threadtests/test_datasets/test_dataset_functions.py
Comment threadtests/test_datasets/test_dataset_functions.py
Comment threadtests/test_datasets/test_dataset_functions.py Outdated
Comment threadtests/test_datasets/test_dataset_functions.py
@codecov-commenter

codecov-commenter commented Sep 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (1d707e6) to head (44dcb03).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@## develop #1352 +/- ##
===========================================
- Coverage 84.33% 84.28% -0.06% 
===========================================
Files 38 38 Lines 5293 5288 -5 ===========================================
- Hits 4464 4457 -7 - Misses 829 831 +2 
FlagCoverage Δ
84.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threadtests/test_openml/test_config.py

@LennartPuruckerLennartPurucker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; very nice refactor of the tests!

Otherwise, no further comments from my side.

Comment threadtests/test_datasets/test_dataset_functions.py Outdated
@PGijsbers
PGijsbers merged commit 07e9b9c into developSep 22, 2024
@PGijsbers
PGijsbers deleted the add/1034 branch September 22, 2024 19:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-commenter@LennartPurucker