Skip to content

fix: Avoid Random State and Other Test Bug - #1362

Merged
LennartPurucker merged 3 commits into
developfrom
LennartPurucker-patch-2
Oct 15, 2024
Merged

fix: Avoid Random State and Other Test Bug#1362
LennartPurucker merged 3 commits into
developfrom
LennartPurucker-patch-2

Conversation

@LennartPurucker

Copy link
Copy Markdown
Contributor

See last failure of tests.

@codecov-commenter

codecov-commenter commented Oct 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (d3bb775) to head (44b36a2).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@## develop #1362 +/- ##
===========================================
+ Coverage 84.07% 84.14% +0.07% 
===========================================
Files 38 38 Lines 5305 5305 ===========================================
+ Hits 4460 4464 +4 + Misses 845 841 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddiebergman

Copy link
Copy Markdown
Collaborator

I had to kill the windows runner as it was running for over 40 minutes without stopping. This seems to happen occasionally, will re-run failed jobs now

@eddiebergmaneddiebergman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming no more sporadic test failures show up

@LennartPuruckerLennartPurucker changed the title Fix Random State Bound Bugfix: Avoid Random State and Other Test BugOct 15, 2024
@LennartPurucker
LennartPurucker merged commit 1dc97eb into developOct 15, 2024
@LennartPurucker
LennartPurucker deleted the LennartPurucker-patch-2 branch October 15, 2024 09:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LennartPurucker@codecov-commenter@eddiebergman