Skip to content

fix: Strip Whitespace New PR - #1363

Closed
LennartPurucker wants to merge 3 commits into
developfrom
add/strip_whitespace
Closed

fix: Strip Whitespace New PR#1363
LennartPurucker wants to merge 3 commits into
developfrom
add/strip_whitespace

Conversation

@LennartPurucker

Copy link
Copy Markdown
Contributor

Rel: #1136, #1125

@PGijsbers I still have not found a good way to fix the edge case where this change would require a cache reset.

I am also trying to figure out how to see if this breaks anything we do not know about (all tests pass).

Cache Reset

Relevant code:

def_read_features(features_file: Path) ->dict[int, OpenMLDataFeature]:
features_pickle_file=Path(_get_features_pickle_file(str(features_file)))
try:
withfeatures_pickle_file.open("rb") asfh_binary:
returnpickle.load(fh_binary) # type: ignore # noqa: S301except: # noqa: E722withPath(features_file).open("r", encoding="utf8") asfh:
features_xml_string=fh.read()
features=_parse_features_xml(features_xml_string)
withfeatures_pickle_file.open("wb") asfh_binary:
pickle.dump(features, fh_binary)
returnfeatures

Let us discuss this in person.

LennartPuruckerand others added 3 commits October 15, 2024 09:57
@codecov-commenter

codecov-commenter commented Oct 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (d3bb775) to head (6db7192).
Report is 3 commits behind head on develop.

Files with missing linesPatch %Lines
openml/datasets/functions.py80.00%2 Missing ⚠️
openml/evaluations/functions.py75.00%1 Missing ⚠️
openml/study/functions.py80.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #1363 +/- ##
========================================
Coverage 84.07% 84.07% ========================================
Files 38 38 Lines 5305 5305 ========================================
Hits 4460 4460 Misses 845 845 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LennartPuruckerLennartPurucker changed the title Fix: Strip Whitespace New PRfix: Strip Whitespace New PROct 15, 2024
@LennartPurucker

Copy link
Copy Markdown
ContributorAuthor

Closing this as a result of recent developments: #1125

@LennartPurucker

Copy link
Copy Markdown
ContributorAuthor

New: #1368

@LennartPurucker
LennartPurucker deleted the add/strip_whitespace branch October 18, 2024 09:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LennartPurucker@codecov-commenter