Skip to content

refactor: Deprecate array formats and default to dataframe - #1372

Merged
LennartPurucker merged 26 commits into
developfrom
refactor-default-dataframe
Jun 17, 2025
Merged

refactor: Deprecate array formats and default to dataframe#1372
LennartPurucker merged 26 commits into
developfrom
refactor-default-dataframe

Conversation

@eddiebergman

Copy link
Copy Markdown
Collaborator

WIP

@codecov-commenter

codecov-commenter commented Oct 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.84291% with 50 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (00d1766) to head (22b6b52).
Report is 3 commits behind head on develop.

Files with missing linesPatch %Lines
openml/study/functions.py17.39%19 Missing ⚠️
openml/datasets/dataset.py78.94%8 Missing ⚠️
openml/evaluations/functions.py81.08%7 Missing ⚠️
openml/runs/functions.py78.12%7 Missing ⚠️
openml/utils.py80.00%3 Missing ⚠️
openml/extensions/sklearn/extension.py77.77%2 Missing ⚠️
openml/setups/functions.py94.28%2 Missing ⚠️
openml/datasets/functions.py95.23%1 Missing ⚠️
openml/tasks/functions.py95.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #1372 +/- ##
===========================================
- Coverage 84.33% 84.18% -0.16% 
===========================================
Files 38 38 Lines 5325 5230 -95 ===========================================
- Hits 4491 4403 -88 + Misses 834 827 -7 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eddiebergman
eddiebergmanforce-pushed the refactor-default-dataframe branch from 53e3cec to 6296f37CompareOctober 17, 2024 15:10
SubhadityaMukherjee
SubhadityaMukherjee previously approved these changes Apr 1, 2025

@SubhadityaMukherjeeSubhadityaMukherjee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks good to me now. Merge conflicts were fixed, target_names was renamed back to target since I could not find a reason to change it everywhere.

@SubhadityaMukherjee

Copy link
Copy Markdown
Contributor

I am not confident in trying to merge it to develop until the tests are up and running again.

@SubhadityaMukherjee
SubhadityaMukherjee dismissed their stale reviewApril 1, 2025 13:42

I am not confident in trying to merge it to develop until the tests are up and running again.

@LennartPuruckerLennartPurucker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did one full pass, LGTM, now looking into tests

Comment threadtests/test_datasets/test_dataset_functions.py Outdated

@PGijsbersPGijsbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much fine to merge

Comment threadopenml/setups/functions.py
Comment threadopenml/utils.py Outdated
Comment threadopenml/utils.py Outdated
Comment threadopenml/setups/setup.py Outdated
Comment threadopenml/setups/setup.py Outdated
LennartPuruckerand others added 6 commits June 17, 2025 15:03
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>

@PGijsbersPGijsbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LennartPurucker
LennartPurucker merged commit d36593d into developJun 17, 2025
@LennartPurucker
LennartPurucker deleted the refactor-default-dataframe branch June 17, 2025 13:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eddiebergman@codecov-commenter@SubhadityaMukherjee@PGijsbers@LennartPurucker