Uh oh!
There was an error while loading. Please reload this page.
refactor: Deprecate array formats and default to dataframe - #1372
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #1372 +/- ##
===========================================
- Coverage 84.33% 84.18% -0.16%
===========================================
Files 38 38 Lines 5325 5230 -95 ===========================================
- Hits 4491 4403 -88 + Misses 834 827 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53e3cec to
6296f37Compare
SubhadityaMukherjee
left a comment
There was a problem hiding this comment.
Okay looks good to me now. Merge conflicts were fixed, target_names was renamed back to target since I could not find a reason to change it everywhere.
SubhadityaMukherjee
commented
Apr 1, 2025
I am not confident in trying to merge it to develop until the tests are up and running again. |
I am not confident in trying to merge it to develop until the tests are up and running again.
LennartPurucker
left a comment
There was a problem hiding this comment.
Did one full pass, LGTM, now looking into tests
Uh oh!
There was an error while loading. Please reload this page.
PGijsbers
left a comment
There was a problem hiding this comment.
Pretty much fine to merge
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
…to refactor-default-dataframe
WIP