Skip to content

Automatically connect to production server based on mark - #1411

Merged
LennartPurucker merged 11 commits into
developfrom
prod-mark-is-prod-test
Jun 18, 2025
Merged

Automatically connect to production server based on mark#1411
LennartPurucker merged 11 commits into
developfrom
prod-mark-is-prod-test

Conversation

@PGijsbers

@PGijsbersPGijsbers commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Idea on how to configure the usage of the server in one place.
Problem is that it still doesn't really work with the existing unittest cases which also execute their own setup/teardown.
... or we also modify the setup/teardown to avoid setting server configuration. brb.

@codecov-commenter

codecov-commenter commented Jun 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.71%. Comparing base (5be0d24) to head (91f3d52).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@## develop #1411 +/- ##
============================================
- Coverage 83.15% 53.71% -29.44% 
============================================
Files 38 38 Lines 5231 5229 -2 ============================================
- Hits 4350 2809 -1541 - Misses 881 2420 +1539 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers
PGijsbersforce-pushed the prod-mark-is-prod-test branch 4 times, most recently from 96de9c5 to f65ee2bCompareJune 18, 2025 09:19
@PGijsbers
PGijsbersforce-pushed the prod-mark-is-prod-test branch from f65ee2b to 32b1320CompareJune 18, 2025 09:24
@PGijsbers
PGijsbersforce-pushed the prod-mark-is-prod-test branch 2 times, most recently from d0e71d2 to 37a31fbCompareJune 18, 2025 10:09
@PGijsbers
PGijsbersforce-pushed the prod-mark-is-prod-test branch from 37a31fb to 44c2bd5CompareJune 18, 2025 12:49
@PGijsbers
PGijsbers marked this pull request as ready for review June 18, 2025 13:22
Comment thread.github/workflows/test.yml
Comment threadtests/test_tasks/test_classification_task.py
@PGijsbers

Copy link
Copy Markdown
CollaboratorAuthor

@LennartPuruckerLennartPurucker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor

Comment threadtests/test_tasks/test_classification_task.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-commenter@LennartPurucker