Uh oh!
There was an error while loading. Please reload this page.
[ENH] V1 → V2 API Migration - evaluation measures - #1603
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1603 +/- ##
==========================================
- Coverage 53.96% 53.75% -0.22%
==========================================
Files 61 61 Lines 5051 5062 +11 ==========================================
- Hits 2726 2721 -5 - Misses 2325 2341 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #1593
Depends on #1576
Related to #1575
geetu040
left a comment
There was a problem hiding this comment.
update with #1576 (comment)
geetu040
left a comment
There was a problem hiding this comment.
@EmanAbdelhaleem Thanks for the PR. Nicely done!
I have updated the PR to sync with latest changes in base PR.
@PGijsbers please review/merge.
PGijsbers
left a comment
There was a problem hiding this comment.
Generally looks good to me, minor changes for the tests. Also holding off for a second due to the CI failures that Armaghan is investigating.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
geetu040
commented
Mar 25, 2026
@PGijsbers I've updated the PR with your suggested changes and the only failing test is sporadic. This should be ready for review/merge. |
Uh oh!
There was an error while loading. Please reload this page.
Fixes#1593
Depends on #1576
Related to #1575
Details
This PR implements
EvaluationMeasuresresource, and refactor its existing functions