Uh oh!
There was an error while loading. Please reload this page.
[ENH] V1 -> V2 Migration : Runs - #1616
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1616 +/- ##
==========================================
- Coverage 81.43% 81.25% -0.19%
==========================================
Files 63 63 Lines 5149 5195 +46 ==========================================
+ Hits 4193 4221 +28 - Misses 956 974 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
sync with base pr
sdk code look good so far, please take a look at #1575 (comment) and make changes accordingly where needed.
all tests (existing and new) should pass to make sure we are retaining the original functionality of the sdk
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
…-11/openml-python into runs-migration-stacked
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
| use_cache = not ignore_cache | ||
| reset_cache = ignore_cache | ||
| return api_context.backend.runs.get( | ||
| run_id, | ||
| use_cache=use_cache, | ||
| reset_cache=reset_cache, | ||
| ) |
There was a problem hiding this comment.
use_cache should be true since the method always supports cachingreset_cache should rely on ignore_cache
for more information, see https://pre-commit.ci
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
geetu040
commented
May 21, 2026
@Omswastik-11 could you go through the above comments, we'd need to close these discussions. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
openml/runs/run.py:373
- The
ObjectNotPublishedErrormessage here diverges from the established tagging error message used byOpenMLBase.remove_tag(viaopenml.utils._tag_openml_base), and it also drops the object context. Consider reusing the same wording/format for consistency across entity types.
if self.run_id is None:
raise openml.exceptions.ObjectNotPublishedError(
"Cannot untag a run that has not been published yet."
" Please publish the run first before being able to untag it.",
)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…-11/openml-python into runs-migration-stacked
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
| def test_run_v1_get(run_v1, with_test_cache): | ||
| import os | ||
| # Run 1 exists on the remote test server; the local docker server only seeds run 25. | ||
| run_id = 25 if os.getenv("OPENML_USE_LOCAL_SERVICES") == "true" else 1 | ||
| run = run_v1.get(run_id=run_id) | ||
| _assert_run_shape(run) |
There was a problem hiding this comment.
we'll use cached run instead, so this can be ignored
Uh oh!
There was an error while loading. Please reload this page.
for more information, see https://pre-commit.ci
Metadata
Details
fixes#1624