Skip to content

Cast data qualities to float - #353

Merged
amueller merged 1 commit into
developfrom
fix_345
Oct 12, 2017
Merged

Cast data qualities to float#353
amueller merged 1 commit into
developfrom
fix_345

Conversation

@mfeurer

@mfeurermfeurer commented Oct 12, 2017

Copy link
Copy Markdown
Collaborator

Fixes#345.

@codecov-io

codecov-io commented Oct 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #353 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## develop #353 +/- ##
==========================================
+ Coverage 89.69% 89.9% +0.21% 
==========================================
Files 32 32 Lines 2522 2626 +104 ==========================================
+ Hits 2262 2361 +99 - Misses 260 265 +5
Impacted FilesCoverage Δ
openml/datasets/functions.py91.52% <100%> (+1.47%)⬆️
openml/datasets/dataset.py79.57% <100%> (+0.71%)⬆️
openml/tasks/functions.py87.55% <0%> (+1.66%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01ef40...aa758f9. Read the comment docs.

@amueller

Copy link
Copy Markdown
Contributor

I'd argue the xsd is wrong? Semantically they are not floats, right?

@amueller

Copy link
Copy Markdown
Contributor

I'd say this is better then before but still kinda stupid ;)

@mfeurer

Copy link
Copy Markdown
CollaboratorAuthor

Some qualities are floats, but some aren't. And except for writing down which to cast as int I wouldn't how to do this.

@amueller
amueller merged commit 6b22bb6 into developOct 12, 2017
@mfeurer
mfeurer deleted the fix_345 branch October 15, 2017 10:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeurer@codecov-io@amueller