Skip to content

WIP dataset Tagging - #355

Merged
amueller merged 3 commits into
openml:developfrom
amueller:tagging
Oct 12, 2017
Merged

WIP dataset Tagging#355
amueller merged 3 commits into
openml:developfrom
amueller:tagging

Conversation

@amueller

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Oct 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #355 into develop will increase coverage by 0.08%.
The diff coverage is 85%.

Impacted file tree graph

@@ Coverage Diff @@## develop #355 +/- ##
===========================================
+ Coverage 89.69% 89.77% +0.08% 
===========================================
Files 32 32 Lines 2522 2542 +20 ===========================================
+ Hits 2262 2282 +20 
Misses 260 260
Impacted FilesCoverage Δ
openml/_api_calls.py90.27% <100%> (+0.27%)⬆️
openml/datasets/functions.py90.19% <100%> (+0.14%)⬆️
openml/exceptions.py100% <100%> (ø)⬆️
openml/datasets/dataset.py80% <70%> (+1.14%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01ef40...96a850b. Read the comment docs.

Comment threadopenml/datasets/dataset.py Outdated

Parameters
----------
tag : string

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be str?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Comment threadopenml/datasets/dataset.py Outdated

Parameters
----------
tag : string

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@amueller
amueller merged commit d05790b into openml:developOct 12, 2017
@mfeurermfeurer mentioned this pull request Oct 16, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amueller@codecov-io@mfeurer