Skip to content

Fix #378 - #418

Merged
mfeurer merged 5 commits into
developfrom
fix378
Mar 14, 2018
Merged

Fix #378#418
mfeurer merged 5 commits into
developfrom
fix378

Conversation

@ArlindKadra

Copy link
Copy Markdown
Member

Fix ascii decoding error with python 2.

@mfeurer

Copy link
Copy Markdown
Collaborator

Please also write a unit test following the example given in #378.

@codecov-io

codecov-io commented Mar 14, 2018

Copy link
Copy Markdown

Codecov Report

Merging #418 into develop will decrease coverage by 0.14%.
The diff coverage is 68.75%.

Impacted file tree graph

@@ Coverage Diff @@## develop #418 +/- ##
===========================================
- Coverage 89.1% 88.95% -0.15% 
===========================================
Files 32 32 Lines 2671 2681 +10 ===========================================
+ Hits 2380 2385 +5 - Misses 291 296 +5
Impacted FilesCoverage Δ
openml/tasks/split.py91.08% <66.66%> (-2.67%)⬇️
openml/datasets/dataset.py77.64% <66.66%> (-0.22%)⬇️
openml/datasets/data_feature.py69.56% <75%> (-0.44%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4387d6...7ef82d8. Read the comment docs.

@mfeurer
mfeurer merged commit deb769e into developMar 14, 2018
@ArlindKadra
ArlindKadra deleted the fix378 branch March 19, 2018 11:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ArlindKadra@mfeurer@codecov-io