Skip to content

MAINT bump required liac-arff version - #427

Merged
mfeurer merged 2 commits into
developfrom
maint/bump_liac_arff_dependency
Mar 29, 2018
Merged

MAINT bump required liac-arff version#427
mfeurer merged 2 commits into
developfrom
maint/bump_liac_arff_dependency

Conversation

@mfeurer

Copy link
Copy Markdown
Collaborator

New version is more resilient with respect to commas in data. However, it cannot yet read all commas, that's for the future.

@mfeurer
mfeurer requested a review from janvanrijnMarch 29, 2018 08:32
@codecov-io

codecov-io commented Mar 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #427 into develop will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #427 +/- ##
==========================================
+ Coverage 89.37% 89.5% +0.12% 
==========================================
Files 32 32 Lines 2683 2744 +61 ==========================================
+ Hits 2398 2456 +58 - Misses 285 288 +3
Impacted FilesCoverage Δ
openml/datasets/dataset.py81.01% <0%> (+3.36%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b701bb...e789e5a. Read the comment docs.

@janvanrijnjanvanrijn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're also maintaining the liac-arff library

@mfeurer

Copy link
Copy Markdown
CollaboratorAuthor

Yep...

@mfeurer
mfeurer merged commit fb20762 into developMar 29, 2018
@mfeurer
mfeurer deleted the maint/bump_liac_arff_dependency branch April 23, 2018 07:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeurer@codecov-io@janvanrijn