Skip to content

[MRG] TST: add test for creating datset from NumPy array - #539

Merged
mfeurer merged 3 commits into
openml:developfrom
glemaitre:is/537
Sep 20, 2018
Merged

[MRG] TST: add test for creating datset from NumPy array#539
mfeurer merged 3 commits into
openml:developfrom
glemaitre:is/537

Conversation

@glemaitre

Copy link
Copy Markdown
Contributor

Reference Issue

closes#537

What does this PR implement/fix? Explain your changes.

Implement a unit test for the function create_dataset from NumPy array.

@glemaitreglemaitre changed the title TST: add test for creating datset from NumPy array[MRG] TST: add test for creating datset from NumPy arraySep 20, 2018

@mfeurermfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #539 into develop will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #539 +/- ##
===========================================
+ Coverage 89.82% 90.07% +0.24% 
===========================================
Files 32 32 Lines 2811 2811 ===========================================
+ Hits 2525 2532 +7 + Misses 286 279 -7
Impacted FilesCoverage Δ
openml/datasets/dataset.py78.22% <0%> (+0.36%)⬆️
openml/datasets/functions.py90.38% <0%> (+2.88%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af0ecb...547608b. Read the comment docs.

@mfeurermfeurer mentioned this pull request Sep 20, 2018
@mfeurer
mfeurer merged commit 55c8c09 into openml:developSep 20, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No unit test for create_dataset

3 participants

@glemaitre@codecov-io@mfeurer