Skip to content

fixes issue #565 and removes future / deprecation warnings - #566

Merged
mfeurer merged 4 commits into
developfrom
fix_#565
Oct 12, 2018
Merged

fixes issue #565 and removes future / deprecation warnings#566
mfeurer merged 4 commits into
developfrom
fix_#565

Conversation

@janvanrijn

Copy link
Copy Markdown
Member

Fixes#565

@mfeurer

Copy link
Copy Markdown
Collaborator

It seems like the tests are failing with older scikit-learn versions.

@codecov-io

codecov-io commented Oct 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #566 into develop will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@ Coverage Diff @@## develop #566 +/- ##
===========================================
- Coverage 89.91% 89.88% -0.03% 
===========================================
Files 32 32 Lines 2915 2917 +2 ===========================================
+ Hits 2621 2622 +1 - Misses 294 295 +1
Impacted FilesCoverage Δ
openml/setups/functions.py94.4% <60%> (-0.73%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba94609...fef6c89. Read the comment docs.

@janvanrijn

Copy link
Copy Markdown
MemberAuthor

I honestly have no clue why the code crashed before. According to my analysis, this should not have happened. I made some changes to the if/else structure of the setup_exists fn, as I had the impression that this was not according to the way it should be. These should have had no influence on the code crashing or not. @mfeurer what do you think?

@mfeurer
mfeurer merged commit 779fb82 into developOct 12, 2018
@mfeurer
mfeurer deleted the fix_#565 branch October 12, 2018 09:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@janvanrijn@mfeurer@codecov-io