Skip to content

Fix #569: crash when sklearn version does not collide - #601

Merged
mfeurer merged 4 commits into
developfrom
fix_#569
Dec 7, 2018
Merged

Fix #569: crash when sklearn version does not collide#601
mfeurer merged 4 commits into
developfrom
fix_#569

Conversation

@janvanrijn

Copy link
Copy Markdown
Member

fixes#569

@janvanrijn
janvanrijn changed the base branch from master to developDecember 5, 2018 19:17
@codecov-io

codecov-io commented Dec 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #601 into develop will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@ Coverage Diff @@## develop #601 +/- ##
=========================================
- Coverage 90.06% 90% -0.07% 
=========================================
Files 32 32 Lines 3001 3000 -1 =========================================
- Hits 2703 2700 -3 - Misses 298 300 +2
Impacted FilesCoverage Δ
openml/flows/flow.py95.07% <ø> (-0.17%)⬇️
openml/flows/functions.py93.33% <80%> (-0.86%)⬇️
openml/flows/sklearn_converter.py91.37% <0%> (-0.27%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d61c4...78db15a. Read the comment docs.

@mfeurer

Copy link
Copy Markdown
Collaborator

Does this also fix #485?

@janvanrijn

Copy link
Copy Markdown
MemberAuthor

I think #485 and this issue are duplicates. #485 is badly described though (you can actually get flows from other workbenches)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_flow crashes when downloading a flow from a different sklearn version

3 participants

@janvanrijn@codecov-io@mfeurer