Uh oh!
There was an error while loading. Please reload this page.
[WIP] Task upload - #607
Conversation
Codecov Report
@@ Coverage Diff @@## develop #607 +/- ##
===========================================
- Coverage 90.67% 90.54% -0.14%
===========================================
Files 36 36 Lines 3690 3743 +53 ===========================================
+ Hits 3346 3389 +43 - Misses 344 354 +10
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6d00fb4 to
2cc2f55CompareUh oh!
There was an error while loading. Please reload this page.
| task_container = super(OpenMLClusteringTask, self)._to_dict() | ||
| task_dict = task_container['oml:task_inputs'] | ||
| task_dict['oml:input'].append( |
There was a problem hiding this comment.
Is the estimation procedure common to all task types? If yes, could you please add it to the parent class?
There was a problem hiding this comment.
Nice observation. It also made me realise that the code for some of the tasks can be incomplete since when the class is downloaded from the server it has more information concerning the estimation procedure.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mfeurer
left a comment
There was a problem hiding this comment.
Hey, this looks really good! Only a few minor comments. I'll approve once the PEP8 stuff is green.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mfeurer
left a comment
There was a problem hiding this comment.
Awesome, I just have a few minor questions/requests, and then we should be good to go with this!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR implement/fix? Explain your changes.
Implements task upload.
Adds a function that allows tasks to be created (facilitates task creation for users compared to the task constructor).
Adds type annotations for the task object.
How should this PR be tested?
New unit tests for different kinds of tasks.
Addresses #657, #656