Uh oh!
There was an error while loading. Please reload this page.
Finish pep8 compliance - #630
Conversation
Codecov Report
@@ Coverage Diff @@## develop #630 +/- ##
========================================
Coverage 89.86% 89.86% ========================================
Files 32 32 Lines 3208 3208 ========================================
Hits 2883 2883 Misses 325 325
Continue to review full report at Codecov.
|
janvanrijn
left a comment
There was a problem hiding this comment.
The PR looks mainly great to me. Can you explain why the script flake8_diff.sh used to be huge, and is now only 3 lines? (Which is great btw)
I have some guessed but would be good to see this confirmed.
mfeurer
commented
Feb 25, 2019
The script was huge because it performed flake8 on the difference between the latest commit and the common ancestor between the current branch and the development branch. These differences had to be fetched and assembled. Now the script simply checks everything. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.