Skip to content

Finish pep8 compliance - #630

Merged
mfeurer merged 2 commits into
developfrom
finish_pep8
Feb 25, 2019
Merged

Finish pep8 compliance#630
mfeurer merged 2 commits into
developfrom
finish_pep8

Conversation

@mfeurer

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-io

codecov-io commented Feb 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #630 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #630 +/- ##
========================================
Coverage 89.86% 89.86% ========================================
Files 32 32 Lines 3208 3208 ========================================
Hits 2883 2883 Misses 325 325
Impacted FilesCoverage Δ
openml/datasets/__init__.py100% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c1edd...7e7949e. Read the comment docs.

@janvanrijnjanvanrijn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks mainly great to me. Can you explain why the script flake8_diff.sh used to be huge, and is now only 3 lines? (Which is great btw)

I have some guessed but would be good to see this confirmed.

@mfeurer

Copy link
Copy Markdown
CollaboratorAuthor

The script was huge because it performed flake8 on the difference between the latest commit and the common ancestor between the current branch and the development branch. These differences had to be fetched and assembled. Now the script simply checks everything.

Comment threadci_scripts/flake8_diff.sh
Comment threadexamples/flows_and_runs_tutorial.py
@PGijsbersPGijsbers mentioned this pull request Feb 25, 2019
@mfeurer
mfeurer merged commit 0980673 into developFeb 25, 2019
@mfeurer
mfeurer deleted the finish_pep8 branch February 25, 2019 09:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mfeurer@codecov-io@janvanrijn@PGijsbers