Skip to content

Add #632 - #633

Merged
janvanrijn merged 5 commits into
developfrom
add_#632
Feb 26, 2019
Merged

Add #632#633
janvanrijn merged 5 commits into
developfrom
add_#632

Conversation

@janvanrijn

@janvanrijnjanvanrijn commented Feb 25, 2019

Copy link
Copy Markdown
Member

Reference Issue

Fixes#632

What does this PR implement/fix? Explain your changes.

How should this PR be tested?

Any other comments?

@janvanrijn
janvanrijn changed the base branch from master to developFebruary 25, 2019 14:28
@codecov-io

codecov-io commented Feb 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #633 into develop will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## develop #633 +/- ##
===========================================
+ Coverage 89.86% 90.03% +0.16% 
===========================================
Files 32 32 Lines 3208 3232 +24 ===========================================
+ Hits 2883 2910 +27 + Misses 325 322 -3
Impacted FilesCoverage Δ
openml/study/__init__.py100% <ø> (ø)⬆️
openml/study/functions.py96.87% <100%> (+1.04%)⬆️
openml/_api_calls.py88.31% <0%> (+3.89%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0980673...4f60c25. Read the comment docs.

Comment threadopenml/study/functions.py Outdated
size : int, optional
The maximum number of studies to show.
main_entity_type : str, optional
Can be `task` or `run`. In case of `task`, only benchmark suites are

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rest you should format as:

``'task'`` or ``'run'``

Comment threadopenml/study/functions.py Outdated
Comment threadtests/test_study/test_study_functions.py
@janvanrijn
janvanrijn merged commit 98a73b3 into developFeb 26, 2019
@janvanrijn
janvanrijn deleted the add_#632 branch February 26, 2019 14:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: study list

3 participants

@janvanrijn@codecov-io@mfeurer