Skip to content

Add support for serializing numpy data types. - #635

Merged
mfeurer merged 2 commits into
developfrom
fix304
Mar 5, 2019
Merged

Add support for serializing numpy data types.#635
mfeurer merged 2 commits into
developfrom
fix304

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

Notes on the fix in #304.

@codecov-io

codecov-io commented Mar 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #635 into develop will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## develop #635 +/- ##
===========================================
- Coverage 90.12% 89.86% -0.27% 
===========================================
Files 32 32 Lines 3232 3236 +4 ===========================================
- Hits 2913 2908 -5 - Misses 319 328 +9
Impacted FilesCoverage Δ
openml/flows/sklearn_converter.py90.48% <100%> (+0.08%)⬆️
openml/_api_calls.py84.41% <0%> (-3.9%)⬇️
openml/tasks/functions.py86.45% <0%> (-1.94%)⬇️
openml/runs/functions.py86.4% <0%> (-0.66%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a73b3...b7686bc. Read the comment docs.

@PGijsbers
PGijsbers requested a review from mfeurerMarch 4, 2019 10:37

@mfeurermfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you please add a unit test ensuring the behavior and also add a check that numpy arrays cannot be serialized?

@PGijsbers

Copy link
Copy Markdown
CollaboratorAuthor

@mfeurer I assumed you would get a ping automatically, but I am not sure if this is the case. I added the tests.

@mfeurer

Copy link
Copy Markdown
Collaborator

I get a ping for a commit, but I usually do not check the commits because I don't know if that commit makes it ready for review again. Will check now.

@mfeurer
mfeurer merged commit 96ddc13 into developMar 5, 2019
@PGijsbersPGijsbers mentioned this pull request Mar 5, 2019
Merged
@PGijsbers
PGijsbers deleted the fix304 branch March 17, 2019 12:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-io@mfeurer