Uh oh!
There was an error while loading. Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## develop #635 +/- ##
===========================================
- Coverage 90.12% 89.86% -0.27%
===========================================
Files 32 32 Lines 3232 3236 +4 ===========================================
- Hits 2913 2908 -5 - Misses 319 328 +9
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
Looks good, could you please add a unit test ensuring the behavior and also add a check that numpy arrays cannot be serialized?
PGijsbers
commented
Mar 5, 2019
@mfeurer I assumed you would get a ping automatically, but I am not sure if this is the case. I added the tests. |
mfeurer
commented
Mar 5, 2019
I get a ping for a commit, but I usually do not check the commits because I don't know if that commit makes it ready for review again. Will check now. |
Notes on the fix in #304.