Skip to content

[MRG] Fix402 - #677

Merged
mfeurer merged 15 commits into
developfrom
fix402
Apr 29, 2019
Merged

[MRG] Fix402#677
mfeurer merged 15 commits into
developfrom
fix402

Conversation

@PGijsbers

@PGijsbersPGijsbers commented Apr 16, 2019

Copy link
Copy Markdown
Collaborator

This PR contributes:

Second contribution and related test updates really should have been a separate PR.
I am sorry for putting it into one, it kinda happened.

Closes#402.
Will need to create a new issue, because I removed this TODO (all TODOs should rather be centralized on the issue tracker, right?).

@PGijsbersPGijsbers changed the title [WIP] Fix402Fix402Apr 26, 2019
@PGijsbersPGijsbers changed the title Fix402[MRG] Fix402Apr 26, 2019
@codecov-io

codecov-io commented Apr 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #677 into develop will decrease coverage by 0.03%.
The diff coverage is 94.73%.

Impacted file tree graph

@@ Coverage Diff @@## develop #677 +/- ##
==========================================
- Coverage 90.54% 90.5% -0.04% 
==========================================
Files 36 36 Lines 3743 3730 -13 ==========================================
- Hits 3389 3376 -13 
Misses 354 354
Impacted FilesCoverage Δ
openml/tasks/task.py94.77% <100%> (ø)⬆️
openml/datasets/dataset.py88.12% <93.33%> (-0.47%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813daeb...09622d6. Read the comment docs.

@PGijsbers
PGijsbers requested a review from mfeurerApril 29, 2019 11:46
Comment threadopenml/datasets/dataset.py Outdated
Comment threadopenml/datasets/dataset.py Outdated
Comment threadtests/test_datasets/test_dataset.py Outdated
Comment threadtests/test_datasets/test_dataset.py
Comment threadtests/test_datasets/test_dataset.py Outdated
Comment threadtests/test_datasets/test_dataset.py Outdated
@mfeurer
mfeurer merged commit 72f131a into developApr 29, 2019
@mfeurer
mfeurer deleted the fix402 branch November 12, 2019 10:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openml.datasets.get_data() has unpredictable number of return values

3 participants

@PGijsbers@codecov-io@mfeurer