Skip to content

Added notice to all examples for using the test server. Use test serv… - #684

Merged
PGijsbers merged 5 commits into
developfrom
update_examples
Apr 23, 2019
Merged

Added notice to all examples for using the test server. Use test serv…#684
PGijsbers merged 5 commits into
developfrom
update_examples

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

Uses the #680 functionality and adds warning messages that the test server is used for examples.

  • This can't be merged before Easy access test server #680.
  • We should go back and rework examples to use the live server if they do not upload anything.

Unfortunately I probably won't have the time to finish this before the weekend (and I won't have time to work on it then, either). Feel free to take over this PR.

@PGijsbers

Copy link
Copy Markdown
CollaboratorAuthor

This was intended to be a draft >.> not sure what happened there

@codecov-io

codecov-io commented Apr 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #684 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #684 +/- ##
========================================
Coverage 90.76% 90.76% ========================================
Files 36 36 Lines 3650 3650 ========================================
Hits 3313 3313 Misses 337 337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ec3ab...c31e6ed. Read the comment docs.

@mfeurer

Copy link
Copy Markdown
Collaborator

@PGijsbers I added your suggestions. Could you please check the changes I made?

@PGijsbers

Copy link
Copy Markdown
CollaboratorAuthor

Looks good. I'm merging this so that we can then update examples with individual PRs as necessary.

@PGijsbers
PGijsbers merged commit 79c1953 into developApr 23, 2019
@PGijsbers
PGijsbers deleted the update_examples branch April 23, 2019 08:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-io@mfeurer