Skip to content

Fix bugs by using live server due to reduced volatility - #698

Merged
mfeurer merged 5 commits into
developfrom
fix_bugs
May 29, 2019
Merged

Fix bugs by using live server due to reduced volatility#698
mfeurer merged 5 commits into
developfrom
fix_bugs

Conversation

@mfeurer

@mfeurermfeurer commented May 28, 2019

Copy link
Copy Markdown
Collaborator

This PR fixes two bugs which were 'introduced' recently by data changes on the test server. This does not include the fix included in #693 and will therefore not fix all unit tests.

@mfeurer
mfeurer requested a review from PGijsbersMay 28, 2019 08:22
@mfeurer

Copy link
Copy Markdown
CollaboratorAuthor

(tests pass on appveyor, presumably due to a different scipy version used for Windows)

@codecov-io

codecov-io commented May 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #698 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #698 +/- ##
===========================================
- Coverage 90.35% 90.33% -0.03% 
===========================================
Files 36 36 Lines 3785 3787 +2 ===========================================
+ Hits 3420 3421 +1 - Misses 365 366 +1
Impacted FilesCoverage Δ
openml/utils.py91.02% <0%> (-0.65%)⬇️
openml/tasks/split.py94.62% <0%> (+0.11%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec86a9...47d460b. Read the comment docs.

@PGijsbers

Copy link
Copy Markdown
Collaborator

What's the reason for not merging in the latest version of dev (with mentioned fix)?

@mfeurer

Copy link
Copy Markdown
CollaboratorAuthor

Actually none, except that I'm not a fan of merging. The PR checks are green now, which should give us enough confidence that this PR does what it's supposed to do.

openml.config.server = self.production_server
flow_id = 6794
setups = openml.setups.list_setups(flow=flow_id, output_format='object', size=10)
print(setups)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the print statement here?

@mfeurer
mfeurer merged commit ca3a25f into developMay 29, 2019
@mfeurer
mfeurer deleted the fix_bugs branch May 29, 2019 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeurer@codecov-io@PGijsbers