Skip to content

Added documentation for creating tasks - #719

Merged
mfeurer merged 17 commits into
developfrom
joaquinvanschoren-patch-1
Jul 26, 2019
Merged

Added documentation for creating tasks#719
mfeurer merged 17 commits into
developfrom
joaquinvanschoren-patch-1

Conversation

@joaquinvanschoren

Copy link
Copy Markdown
Contributor

Documents the task upload functionality.

@codecov-io

codecov-io commented Jun 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #719 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #719 +/- ##
======================================
Coverage 88% 88% ======================================
Files 36 36 Lines 4077 4077 ======================================
Hits 3588 3588 Misses 489 489

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c806b...01e63d5. Read the comment docs.

@PGijsbers

Copy link
Copy Markdown
Collaborator

Is this PR ready for review?

@mfeurermfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this example. In general this looks good and I left a few remarks here and there. The only real issue right now is that it does not execute on the test server. Could you please have a look into that?

Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
@joaquinvanschoren

Copy link
Copy Markdown
ContributorAuthor

Ehm, tests now fail becausepytest: error: unrecognized arguments: --duration=20
What's up with that?

Also, when you said "it does not execute on the test server", did you mean that the test fails or it doesn't even get executed? Do I need to register it somewhere?

@PGijsbers

Copy link
Copy Markdown
Collaborator

Ehm, tests now fail becausepytest: error: unrecognized arguments: --duration=20
What's up with that?

This is fixed on develop. It has to do with an upgrade to Pytest 5.0, see #728. I'm not sure if it's better to merge with develop or just cherry-pick f66c27c (@mfeurer).

@mfeurer

Copy link
Copy Markdown
Collaborator

I'm not sure if it's better to merge with develop or just cherry-pick

I'd prefer rebase, but merging the development branch into this branch should also be fine.

Comment threadexamples/tasks_tutorial.py Outdated
Comment threadexamples/tasks_tutorial.py Outdated
@mfeurer

Copy link
Copy Markdown
Collaborator

Looks good overall, I'd be happy to merge once the tests pass

@mfeurermfeurer mentioned this pull request Jul 19, 2019
@NeeratyoyNeeratyoy self-assigned this Jul 24, 2019
@Neeratyoy
Neeratyoy requested a review from mfeurerJuly 25, 2019 12:25
Comment threadexamples/tasks_tutorial.py
@Neeratyoy
Neeratyoy requested a review from mfeurerJuly 25, 2019 14:51
@mfeurer
mfeurer merged commit 1f5d6a2 into developJul 26, 2019
@mfeurer
mfeurer deleted the joaquinvanschoren-patch-1 branch July 26, 2019 13:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joaquinvanschoren@codecov-io@PGijsbers@mfeurer@Neeratyoy