Uh oh!
There was an error while loading. Please reload this page.
replace __str__ by __repr__ - #743
Conversation
amueller
commented
Jul 22, 2019
test failure in test_list_datasets_with_high_size_parameter seems unrelated? |
mfeurer
commented
Jul 23, 2019
yep, it is. This one might fail sporadically if we concurrently delete stuff from the test server. |
Neeratyoy
commented
Jul 23, 2019
Thanks a lot, @amueller. |
Codecov Report
@@ Coverage Diff @@## develop #743 +/- ##
===========================================
+ Coverage 87.89% 87.98% +0.08%
===========================================
Files 36 36 Lines 4033 4077 +44 ===========================================
+ Hits 3545 3587 +42 - Misses 488 490 +2
Continue to review full report at Codecov.
|
amueller
commented
Jul 24, 2019
Do you have an idea of why this fails on windows? That should be working, right? |
mfeurer
commented
Jul 24, 2019
Nope, maybe @PGijsbers knows. He (together with @WilliamRaynaut) set up the Windows tests and had some regex issues back then, too. |
PGijsbers
commented
Jul 24, 2019
I'm not sure. I tried the tests locally and they work on my Windows machine. |
amueller
commented
Jul 24, 2019
I might have gotten it. |
amueller
commented
Jul 24, 2019
hm still fails on linux on 3.5 :-/ |
PGijsbers
commented
Jul 24, 2019
I saw you were working on fixing it, so I checked against older versions too. All commits in this PR left me with passing unit tests (at least those that |
amueller
commented
Jul 24, 2019
failures seem unrelated now. |
amueller
commented
Jul 25, 2019
yay thank you! |
Closes#739, #75
cc @Neeratyoy, @mfeurer