Skip to content

MRG Sklearn 0.21 compatibility and CI - #752

Merged
mfeurer merged 19 commits into
openml:developfrom
amueller:sklearn_21
Jul 26, 2019
Merged

MRG Sklearn 0.21 compatibility and CI#752
mfeurer merged 19 commits into
openml:developfrom
amueller:sklearn_21

Conversation

@amueller

Copy link
Copy Markdown
Contributor

Working on #749.

Comment threadtests/test_flows/test_flow.py Outdated
Comment threadtests/test_runs/test_run_functions.py Outdated
@amuelleramueller changed the title WIP Sklearn 0.21 compatibility and CIMRG Sklearn 0.21 compatibility and CIJul 25, 2019
@amueller

Copy link
Copy Markdown
ContributorAuthor

tests pass locally on 0.22.dev0, let's see what CI says

@codecov-io

codecov-io commented Jul 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #752 into develop will decrease coverage by 0.08%.
The diff coverage is 60%.

Impacted file tree graph

@@ Coverage Diff @@## develop #752 +/- ##
===========================================
- Coverage 87.93% 87.84% -0.09% 
===========================================
Files 36 37 +1 Lines 4086 4082 -4 ===========================================
- Hits 3593 3586 -7 - Misses 493 496 +3
Impacted FilesCoverage Δ
openml/_backport.py60% <60%> (ø)
openml/exceptions.py84.37% <0%> (-9.38%)⬇️
openml/utils.py91.13% <0%> (-0.64%)⬇️
openml/runs/functions.py81.79% <0%> (-0.29%)⬇️
openml/flows/flow.py93.8% <0%> (-0.06%)⬇️
openml/testing.py96.38% <0%> (ø)⬆️
openml/datasets/dataset.py84.07% <0%> (ø)⬆️
openml/extensions/sklearn/extension.py91.32% <0%> (+0.11%)⬆️
openml/datasets/functions.py95.48% <0%> (+0.32%)⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59cc46...bdbb1f4. Read the comment docs.

@amueller

Copy link
Copy Markdown
ContributorAuthor

Not sure what's up with the dict on windows...

@mfeurermfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Windows tests use Python3.5, and therefore, you're dicts are not sorted. Could that be the issue?

Comment thread.travis.yml
Comment threadopenml/_backport.py Outdated
Comment threadtests/test_flows/test_flow.py Outdated
@mfeurer
mfeurer merged commit e6ee09d into openml:developJul 26, 2019
@amueller

Copy link
Copy Markdown
ContributorAuthor

Thank you! Sweet :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amueller@codecov-io@mfeurer