Uh oh!
There was an error while loading. Please reload this page.
MRG Sklearn 0.21 compatibility and CI - #752
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
amueller
commented
Jul 25, 2019
tests pass locally on 0.22.dev0, let's see what CI says |
Codecov Report
@@ Coverage Diff @@## develop #752 +/- ##
===========================================
- Coverage 87.93% 87.84% -0.09%
===========================================
Files 36 37 +1 Lines 4086 4082 -4 ===========================================
- Hits 3593 3586 -7 - Misses 493 496 +3
Continue to review full report at Codecov.
|
amueller
commented
Jul 25, 2019
Not sure what's up with the dict on windows... |
mfeurer
left a comment
There was a problem hiding this comment.
I think the Windows tests use Python3.5, and therefore, you're dicts are not sorted. Could that be the issue?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
amueller
commented
Jul 26, 2019
Thank you! Sweet :) |
Working on #749.