Skip to content

Convert non-str column names to str when creating a dataset. - #851

Merged
PGijsbers merged 2 commits into
developfrom
Fix819
Oct 23, 2019
Merged

Convert non-str column names to str when creating a dataset.#851
PGijsbers merged 2 commits into
developfrom
Fix819

Conversation

@PGijsbers

Copy link
Copy Markdown
Collaborator

Do I add a regression test?

@mfeurermfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a test (using for example the minimal failing example) would be great.

@PGijsbersPGijsbers mentioned this pull request Oct 23, 2019
@codecov-io

codecov-io commented Oct 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #851 into develop will increase coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## develop #851 +/- ##
===========================================
+ Coverage 88.41% 88.91% +0.49% 
===========================================
Files 37 37 Lines 4271 4716 +445 ===========================================
+ Hits 3776 4193 +417 - Misses 495 523 +28
Impacted FilesCoverage Δ
openml/datasets/functions.py94.11% <100%> (+0.05%)⬆️
openml/_api_calls.py82.14% <0%> (-1.2%)⬇️
openml/base.py90% <0%> (-0.39%)⬇️
openml/runs/run.py87.78% <0%> (-0.25%)⬇️
openml/flows/flow.py93.77% <0%> (+0.67%)⬆️
openml/utils.py91.84% <0%> (+0.93%)⬆️
openml/datasets/dataset.py90.26% <0%> (+3.05%)⬆️
openml/tasks/task.py87.01% <0%> (+3.12%)⬆️
openml/study/study.py78.7% <0%> (+6.2%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56fa7f9...a1f4c08. Read the comment docs.

@PGijsbers
PGijsbers merged commit 1c025db into developOct 23, 2019
@PGijsbers
PGijsbers deleted the Fix819 branch October 23, 2019 14:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PGijsbers@codecov-io@mfeurer