Uh oh!
There was an error while loading. Please reload this page.
Conversation
PGijsbers
commented
Oct 29, 2019
Looks like tests fail due to server issues, otherwise the change looks good to me. |
mfeurer
commented
Oct 29, 2019
Yes, trying to fix them together with @janvanrijn (this PR is part of it). |
janvanrijn
commented
Oct 29, 2019
I disagree. The unit tests seem to assert that there are 2 public versions of the iris dataset on the test server, which is an incorrect assumption, especially after we reset the testserver. |
mfeurer
commented
Oct 29, 2019
This PR changes this. The unit test now assumes that there are 2 public versions of the iris dataset on the live server. |
janvanrijn
commented
Oct 29, 2019
That seems perfectly reasonable to me. This solves issue #858. |
PGijsbers
commented
Oct 29, 2019
I meant the CI results on this PR came back negative, but those were due to server issues. This was unrelated to the change made for this PR, which was not a server issue. |
janvanrijn
commented
Oct 29, 2019
can you point out specifically which failing unit tests you refer to? Some might fail due to recent reset of test server. |
PGijsbers
commented
Oct 30, 2019
Errors like this. I don't think they are persistent bugs, and might well have to do with the recent reset - I'm not saying the server is broken. But for the purpose of an |
Closes#858 by using the live instead of the test server.