Skip to content

Add debug output - #860

Merged
mfeurer merged 6 commits into
developfrom
add_debug_output
Nov 4, 2019
Merged

Add debug output#860
mfeurer merged 6 commits into
developfrom
add_debug_output

Conversation

@mfeurer

Copy link
Copy Markdown
Collaborator

to find the cause of previously failing unit tests.

def _check_run(self, run):
self.assertIsInstance(run, dict)
self.assertEqual(len(run), 7)
assert len(run) == 7, str(run)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please explain in comments why 7? is not clear from the (direct) context

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the amount of entries per run returned by the API: https://openml.org/api/v1/xml/run/list/flow/1154

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit explaining this. I will merge once the tests are through.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good. I am not sure if we should really check this, as this is flexible for extension. But in those cases we can adjust the unit tests as well

@codecov-io

codecov-io commented Oct 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #860 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #860 +/- ##
===========================================
+ Coverage 88.36% 88.43% +0.07% 
===========================================
Files 37 37 Lines 4272 4272 ===========================================
+ Hits 3775 3778 +3 + Misses 497 494 -3
Impacted FilesCoverage Δ
openml/_api_calls.py85.71% <0%> (+3.57%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a13100...aed857f. Read the comment docs.

Comment threadexamples/30_extended/tasks_tutorial.py
@mfeurer
mfeurer merged commit 882b06b into developNov 4, 2019
@mfeurer
mfeurer deleted the add_debug_output branch November 4, 2019 09:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mfeurer@codecov-io@janvanrijn@Neeratyoy@PGijsbers