Uh oh!
There was an error while loading. Please reload this page.
test(skills): preserve native Pi loading and session lifecycle - #322
Merged
tt-a1i merged 6 commits intoAug 31, 2026
Merged
Conversation
Collaborator
感谢 @bkyssn 和 @sowen1023 的投入。这里由维护者统一整合:以 #322 的 Session 实现为基础,纳入 #321 的 TUI 补全和相关测试,并修复评审发现的队列、压缩与解析边界问题。整合、冲突处理和验证由我们负责,采用的代码会保留原作者贡献与共同署名。请先不用继续重复修改这两块;我们会在整合结果通过验证后合并主 PR,再将另一 PR 标明已整合并关闭。当前尚未合并。 |
This was referenced Aug 31, 2026
…ections Integrate the autocomplete adapter and Editor tests from bkyssn/openpi PR openpi-dev#321 into sowen1023/openpi PR openpi-dev#322. Preserve run-scoped Skill snapshots through native compaction and repair Unicode and autocomplete composition boundaries. Co-authored-by: lwc <1803086257@qq.com>
Collaborator
整合提交已推送:
该提交的 GitHub CI 已全部通过:run 33367106344,包含 Node 22.19.0、Node 24 和 Windows。当前仅剩独立人工审批门禁,尚未合并;维护者正在确认收口方式。合并后将 #321 标明已整合关闭,并在最终 squash 提交保留两位贡献者署名。 |
21 tasks
tt-a1i
commented
Aug 31, 2026
Collaborator
原生方案提交与验证回执(2026-08-31)当前 head:
剩余门槛:需要另一位有 write 权限、且不是最后推送者的成员 approve 当前版本。 本次没有自批、修改分支保护、开启 auto-merge 或执行合并。模型效果与新终端 UI 验收未新增声明。 |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refs #282, #316, #317.
Scope update, 2026-08-31: following the accepted native-Pi decision, this PR no longer adds inline
$skillinvocation or hidden Skill-body recovery. The old candidate correctly implemented the earlier requirement; the maintainer has now narrowed that requirement.Value
Keep Pi as the owner of Skill discovery, invocation, normal history and compaction. Avoid a separate OpenPI body cache, provider-only projection and recovery lifecycle. Users explicitly invoke
/skill:name; models can read discovered Skills using the ordinaryreadtool.Approach
ba550bc1d918147c326840276eff018b505ed9d8, production extensions, package manifest and lockfile are unchanged. The net PR is documentation and tests. The removal is relative to the previous unmerged candidate, not a removal from shipped main.Validation
bun run check: passed (configuration/discipline checks, format, lint, typecheck).$skilltest fails because hidden bodies are injected; after removal, the complete new suite passes.bun run test: 1086 Node tests passed, 1 platform-specific skip; 30 Vitest tests passed on the final rerun. The first pre-submit full run hit two existing Subagent watchdog timing failures; both passed in isolation and the full rerun passed without source changes. Those earlier failures are not being hidden or treated as Skill regressions..git diff --checkand Decision/README local-link checks: passed.Impact
$skillis ordinary text, with no OpenPI automatic-loading or inline multi-reference guarantee.Contributions and history
The earlier work by sowen1023 and bkyssn remains credited in the commit history and linked PRs. Its runtime mechanism is retired because of the maintainer's scope decision, not because those contributors failed the original requirement.
Current revision
89f6c88fab44e489be38d276d76c7f9cd63c655f.