Skip to content

Use constant instead of string literal#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leits merged 1 commit into from
Jun 27, 2018
Merged

Use constant instead of string literal #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openprocurement_client/constants.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,9 +11,10 @@
ELIGIBILITY_DOCUMENTS = 'eligibility_documents'
FINANCIAL_DOCUMENTS = 'financial_documens'
LOTS = 'lots'
MILESTONES = 'milestones'
PLANS = 'plans'
QUALIFICATION_DOCUMENTS = 'qualificationDocuments'
QUALIFICATIONS = 'qualifications'
QUALIFICATION_DOCUMENTS = 'qualificationDocuments'
QUESTIONS = 'questions'
TENDERS = 'tenders'
TRANSFERS = 'transfers'
4 changes: 2 additions & 2 deletions openprocurement_client/resources/contracts.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
from openprocurement_client.clients import APIResourceClient
from openprocurement_client.constants import CHANGES, CONTRACTS
from openprocurement_client.constants import CHANGES, CONTRACTS, MILESTONES


class ContractingClient(APIResourceClient):
Expand DownExpand Up@@ -40,5 +40,5 @@ def patch_change(self, contract_id, change_id, access_token, data):

def patch_milestone(self, contract_id, milestone_id, access_token, data):
return self.patch_resource_item_subitem(
contract_id, data, 'milestones', milestone_id, access_token=access_token
contract_id, data, MILESTONES, milestone_id, access_token=access_token
)