Skip to content

Convert Java JUnit unit tests to Groovy Spock specs - #3146

Merged
wborn merged 6 commits into
masterfrom
enhancement/spock-unit-tests
Aug 11, 2026
Merged

Convert Java JUnit unit tests to Groovy Spock specs#3146
wborn merged 6 commits into
masterfrom
enhancement/spock-unit-tests

Conversation

@ebariaux

@ebariauxebariaux commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ebariauxebariaux added the Enhancement Improvement of an existing feature label Aug 3, 2026
@ebariaux
ebariaux marked this pull request as ready for review August 4, 2026 12:57
@ebariaux
ebariaux requested a review from a teamAugust 4, 2026 12:57
@ebariauxebariaux linked an issue Aug 4, 2026 that may be closed by this pull request
Convert JUnit java test to Spock #2752
Closed
@Ekhorn
Ekhorn requested review from Ekhorn and removed request for a teamAugust 4, 2026 14:30
wborn
wborn reviewed Aug 9, 2026
View reviewed changes

@wbornwborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an AI review before manual review.

Overall, the JUnit-to-Spock migration looks good. The converted tests generally preserve the existing behavior while making several tests more concise and data-driven, and most of the new specs follow the conventions already used by OpenRemote's existing Spock tests.

One substantive issue was found where the converted WebServiceEntitySizeConfigTest no longer rejects unexpected service lookups. Two additional non-blocking comments concern making the converted tests more idiomatic and consistent with the existing Spock suite.

No other issues were found in the current changes.

Comment threadcontainer/src/test/groovy/org/openremote/container/web/WebServiceEntitySizeConfigTest.groovy Outdated
Comment threadmodel/src/test/groovy/org/openremote/model/util/JSONSchemaUtilTest.groovy Outdated
Comment threadmodel/src/test/groovy/org/openremote/model/util/LockByKeyTest.groovy
@ebariaux
ebariaux requested a review from wbornAugust 11, 2026 08:37
@sonarqubecloud

sonarqubecloudBot commented Aug 11, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wborn
wborn reviewed Aug 11, 2026
View reviewed changes

@wbornwborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI re-reviewed the current changes and found no further issues. The previous review comments have been addressed.

A human maintainer review is still needed.

wborn
wborn approved these changes Aug 11, 2026
View reviewed changes

@wbornwborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn
wborn merged commit 9a82cf4 into masterAug 11, 2026
24 checks passed
@wborn
wborn deleted the enhancement/spock-unit-tests branch August 11, 2026 08:58
@wbornwborn mentioned this pull request Aug 28, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbornwbornwborn approved these changes
@EkhornEkhornAwaiting requested review from Ekhorn

Assignees

No one assigned

Labels

EnhancementImprovement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert JUnit java test to Spock

3 participants

@ebariaux@wborn@Ekhorn