Uh oh!
There was an error while loading. Please reload this page.
Added CUSTOM_CERT_DIR and ad-hoc self signed cert generation - #27
Merged
Conversation
richturner
marked this pull request as draft
May 15, 2026 13:55
Uh oh!
There was an error while loading. Please reload this page.
richturner
marked this pull request as ready for review
May 15, 2026 21:35
pankalog
previously approved these changes
May 18, 2026
richturner
commented
May 18, 2026
MemberAuthor
This has been deployed and tested on |
Uh oh!
There was an error while loading. Please reload this page.
ebariaux
self-requested a review
May 19, 2026 07:22
ebariaux
approved these changes
May 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't possible to volume map in an additional directory of custom SSL certificates, with this change it is now easy to volume map the
deployment-datavolume to/dataand load custom certs from/data/proxy/certs.By generating the self signed cert on the fly at startup we avoid needing to renew it in the repo itself.