[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237

Merged
penghuo merged 1 commit into
2.xfrom
backport/backport-1231-to-2.x
Jan 9, 2023
Merged

[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom
backport/backport-1231-to-2.x

Conversation

@opensearch-trigger-bot

@opensearch-trigger-botopensearch-trigger-botBot commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Backport dce7d0e from #1231

@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot requested a review from a team as a code ownerJanuary 6, 2023 18:59
@codecov-commenter

codecov-commenter commented Jan 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.
The diff coverage is n/a.

@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo
penghuo merged commit 628be97 into 2.xJan 9, 2023
@github-actions
github-actionsBot deleted the backport/backport-1231-to-2.x branch January 9, 2023 18:05
@dai-chendai-chen added the enhancement New feature or request label Jan 9, 2023
penghuo added a commit that referenced this pull request Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes
+1 more reviewer
@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function - #1237
Merged
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Jan 9, 2023
Merged
[Backport 2.x] Add Second_Of_Minute Function As An Alias Of The Second Function#1237
penghuo merged 1 commit into
2.xfrom 
backport/backport-1231-to-2.x
Conversation
@opensearch-trigger-bot
@opensearch-trigger-botopensearch-trigger-botBot
commented
Jan 6, 2023

Copy link


Copy Markdown

Contributor
Backport dce7d0e from #1231
@GabeFernandez310@github-actions
Add Second_Of_Minute Function As An Alias Of The Second Function (#1231)
e9a7d47
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
@opensearch-trigger-bot
opensearch-trigger-botBot
requested a review
from a team
as a code ownerJanuary 6, 2023 18:59
@codecov-commenter
codecov-commenter
commented
Jan 6, 2023

Copy link


Copy Markdown

Codecov Report
Merging #1237 (e9a7d47) into 2.x (9d7a6eb) will decrease coverage by 35.56%.

The diff coverage is n/a.
@@ Coverage Diff @@## 2.x #1237 +/- ##
=============================================
- Coverage 98.33% 62.76% -35.57% 
=============================================
Files 346 10 -336 Lines 8825 658 -8167 Branches 559 119 -440 =============================================
- Hits 8678 413 -8265 - Misses 142 192 +50 - Partials 5 53 +48 
FlagCoverage Δ
query-workbench62.76% <ø> (?)
sql-engine?
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted FilesCoverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...nsearch/sql/expression/window/WindowFunctions.java
.../opensearch/sql/planner/logical/LogicalRemove.java
...a/org/opensearch/sql/data/model/ExprNullValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
.../expression/operator/convert/TypeCastOperator.java
...a/org/opensearch/sql/data/model/ExprLongValue.java
...nsearch/data/value/OpenSearchExprValueFactory.java
... and 346 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@penghuo
penghuo
merged commit 628be97
into
2.xJan 9, 2023
@github-actions
github-actionsBot
deleted the

backport/backport-1231-to-2.x

branch
January 9, 2023 18:05
@dai-chendai-chen
added
the 
enhancement
New feature or request
label
Jan 9, 2023
penghuo added a commit
that referenced
this pull request
Jan 10, 2023
@penghuo@zelinh
@GabeFernandez310@YANG-DB@opensearch-trigger-bot@vamsimanohar@Yury-Fridlyand@dai-chen@joshuali925
Merge pull request#1260from penghuo/hp/2.5-release
72a3867
* Add BWC tests for running against distribution bundle. (#1209)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
* Add Alternate Syntax For Match_Query And Other Functions (#1166)
Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix
Hot Fix For CI Build
(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Fixed error with single timestamp query (#1244) (#1246)
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit ee949cc)
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)
Added Testing And Implementation For Second_Of_Minute Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit dce7d0e)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)
* Add functions `ADDTIME` and `SUBTIME`. (#132)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 7630f87)
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)
Added Implementation And Testing For Day_Of_Week Function
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit bac9c37)
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)
* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)
Added Testing And Implementation For Minute_Of_Hour Function
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 61e2374)
* Added Missing Imports
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)
* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Support JOIN query on object field with unexpanded name (#1229) (#1250)
* Resolve sub object field in search hit source
Signed-off-by: Chen Dai <daichen@amazon.com>
* Rename to unexpanded object
Signed-off-by: Chen Dai <daichen@amazon.com>
* Update IT with where condition
Signed-off-by: Chen Dai <daichen@amazon.com>
* Fix test index mapping
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 151f4cc)
Co-authored-by: Chen Dai <daichen@amazon.com>
* Remove unnecessary scripts after repo split (#1256)
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)
Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
(cherry picked from commit 6e72f18)
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Co-authored-by: YANGDB <yang.db.dev@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <reddyvam@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@penghuopenghuopenghuo approved these changes

+1 more reviewer

@Yury-FridlyandYury-FridlyandYury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

enhancementNew feature or request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter@penghuo@Yury-Fridlyand@dai-chen@GabeFernandez310