Merge develop into main - #142

Merged
davidcui1225 merged 15 commits into
mainfrom
develop
Jun 26, 2021
Merged

Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom
develop

Conversation

@davidcui1225

@davidcui1225davidcui1225 commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Description

Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

penghuoand others added 8 commits June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Jun 25, 2021•
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chloe-zh

chloe-zh commented Jun 25, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think

@joshuali925

joshuali925 commented Jun 25, 2021

Copy link
Copy Markdown
Member

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

@chloe-zh

chloe-zh commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.

chloe-zh
chloe-zh approved these changes Jun 25, 2021
View reviewed changes

@chloe-zhchloe-zh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!

@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925 reviewed Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md Outdated
@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo approved these changes Jun 26, 2021
View reviewed changes

@penghuopenghuo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225 merged commit 254510e into mainJun 26, 2021
@davidcui1225
davidcui1225 deleted the develop branch June 26, 2021 00:47
@acarbonettoacarbonetto mentioned this pull request Nov 3, 2022
Closed
@Yury-FridlyandYury-Fridlyand mentioned this pull request Feb 2, 2023
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes
+1 more reviewer
@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Merge develop into main  - #142
Merged
davidcui1225 merged 15 commits into
mainfrom 
develop
Jun 26, 2021
Merged
Merge develop into main #142
davidcui1225 merged 15 commits into
mainfrom 
develop
Conversation
@davidcui1225
@davidcui1225davidcui1225
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Description
Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
penghuoand others
added 8 commits
June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6
…tage (#108)
* Support construct AggregationResponseParser during Aggregator build stage
* modify the doc
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80
* impl variance frontend and backend
* Support construct AggregationResponseParser during Aggregator build stage
* add var and varp for PPL
Signed-off-by: penghuo <penghuo@gmail.com>
* add UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix doc format
Signed-off-by: penghuo <penghuo@gmail.com>
* fix the doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add stddev_samp and stddev_pop
Signed-off-by: penghuo <penghuo@gmail.com>
* fix UT coverage
* address comments
Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* Added test case where filtered agg is not pushed down
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
* update
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2
* Deprecated cursor enabling and fetch size setting
Signed-off-by: penghuo <penghuo@gmail.com>
* update doc
Signed-off-by: penghuo <penghuo@gmail.com>
* add more deprecated settings
Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060
* add codecov to CI workflow
Signed-off-by: David Cui <davidcui@amazon.com>
* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225@dependabot
Add Docs and link checker workflow (#139)
d513f79
* save progress on doc renaming
* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>
* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>
* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)
---
updated-dependencies:
- dependency-name: glob-parent
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>
* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>
* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
codecov-commenter
commented
Jun 25, 2021•

edited by codecov
Bot
Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage ? 99.89% Complexity ? 2471 =======================================
Files ? 245 Lines ? 5748 Branches ? 333 =======================================
Hits ? 5742 Misses ? 5 Partials ? 1 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chloe-zh
chloe-zh
commented
Jun 25, 2021•

edited

Loading

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think
@joshuali925
joshuali925
commented
Jun 25, 2021

Copy link


Copy Markdown

Member
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
@chloe-zh
chloe-zh
commented
Jun 25, 2021

Copy link


Copy Markdown

Contributor
Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before
I checked #128 as well, but this PR merges develop to main, I don't think it is affected?
My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.
chloe-zh
chloe-zh
approved these changes
Jun 25, 2021
View reviewed changes
@chloe-zhchloe-zh
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!
@davidcui1225
add links to exclude from link checker
29d26c7
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925
joshuali925
reviewed
Jun 25, 2021
View reviewed changes
Comment threadsql-odbc/docs/dev/sign_installers.md
Outdated

@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa
…rs url
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo
approved these changes
Jun 26, 2021
View reviewed changes
@penghuopenghuo
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!
@davidcui1225
remove sign installers as it is out of date
692f514
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
davidcui1225
merged commit 254510e
into
mainJun 26, 2021
@davidcui1225
davidcui1225
deleted the

develop

branch
June 26, 2021 00:47
@acarbonettoacarbonetto
mentioned this pull request
Nov 3, 2022

Closed

@Yury-FridlyandYury-Fridlyand
mentioned this pull request
Feb 2, 2023
 Merged

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@joshuali925joshuali925joshuali925 approved these changes
@penghuopenghuopenghuo approved these changes

+1 more reviewer

@chloe-zhchloe-zhchloe-zh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@davidcui1225@codecov-commenter@chloe-zh@joshuali925@penghuo@zhongnansu