Uh oh!
There was an error while loading. Please reload this page.
[Spotless] Applying Google Code Format for common #7 - #1940
Merged
GumpacG merged 4 commits intoAug 14, 2023
Conversation
MitchellGale
requested review from
GumpacG, MaxKsyunz, Swiddis, YANG-DB, Yury-Fridlyand, acarbonetto, anirudha, dai-chen, derek-ho, forestmvey, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar
as code ownersAugust 5, 2023 05:17
Comment on lines
+25
to
+36
| "%\\{" | ||
| + "(?<name>" | ||
| + "(?<pattern>[A-z0-9]+)" | ||
| + "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?" | ||
| + ")" | ||
| + "(?:=(?<definition>" | ||
| + "(?:" | ||
| + "(?:[^{}]+|\\.+)+" | ||
| + ")+" | ||
| + ")" | ||
| + ")?" | ||
| + "\\}"); |
Check failure
Code scanning / CodeQL
Inefficient regular expression
Comment on lines
+25
to
+36
| "%\\{" | ||
| + "(?<name>" | ||
| + "(?<pattern>[A-z0-9]+)" | ||
| + "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?" | ||
| + ")" | ||
| + "(?:=(?<definition>" | ||
| + "(?:" | ||
| + "(?:[^{}]+|\\.+)+" | ||
| + ")+" | ||
| + ")" | ||
| + ")?" | ||
| + "\\}"); |
Check failure
Code scanning / CodeQL
Inefficient regular expression
Comment on lines
+25
to
+36
| "%\\{" | ||
| + "(?<name>" | ||
| + "(?<pattern>[A-z0-9]+)" | ||
| + "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?" | ||
| + ")" | ||
| + "(?:=(?<definition>" | ||
| + "(?:" | ||
| + "(?:[^{}]+|\\.+)+" | ||
| + ")+" | ||
| + ")" | ||
| + ")?" | ||
| + "\\}"); |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Comment on lines
+25
to
+36
| "%\\{" | ||
| + "(?<name>" | ||
| + "(?<pattern>[A-z0-9]+)" | ||
| + "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?" | ||
| + ")" | ||
| + "(?:=(?<definition>" | ||
| + "(?:" | ||
| + "(?:[^{}]+|\\.+)+" | ||
| + ")+" | ||
| + ")" | ||
| + ")?" | ||
| + "\\}"); |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Codecov Report
@@ Coverage Diff @@## main #1940 +/- ##
=========================================
Coverage 97.51% 97.51% Complexity 4657 4657 =========================================
Files 408 408 Lines 11933 11933 Branches 829 829 =========================================
Hits 11637 11637 Misses 289 289 Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
GumpacG
previously approved these changes
Aug 8, 2023
Yury-Fridlyand
previously approved these changes
Aug 8, 2023
MitchellGale
dismissed stale reviews from Yury-Fridlyand and GumpacG
via
August 10, 2023 19:24
eaea0e9Yury-Fridlyand
previously approved these changes
Aug 10, 2023
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGaleforce-pushed
the
integ/sl_GoogleJavaFormat7
branch
from
August 14, 2023 19:41
dee7452 to
baacd66CompareGumpacG
approved these changes
Aug 14, 2023
Yury-Fridlyand
approved these changes
Aug 14, 2023
MitchellGale added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…ect#1940) * Spotless apply for common directory. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Igoring checkstyle for common Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply on string utils, Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Typo fix Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…ect#1940) * Spotless apply for common directory. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Igoring checkstyle for common Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply on string utils, Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Typo fix Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…ect#1940) * Spotless apply for common directory. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Igoring checkstyle for common Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply on string utils, Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Typo fix Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for Google Java Code Format for the common directory.
Note: #889 for the codeql bot comments below.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.