Changed the ODBC build platform to MacOS 10.15 from latest - #229

Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom
chloe-zh:issue/odbc-1005
Closed

Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom
chloe-zh:issue/odbc-1005

Conversation

@chloe-zh

@chloe-zhchloe-zh commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Description

The ODBC build fails but the build on macos 10.15 and earlier is working fine.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh closed this Oct 8, 2021
dblock
dblock reviewed Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
build-mac:
runs-on: macos-latest
runs-on: macos-11

@dblockdblockOct 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?

Yury-Fridlyand added a commit that referenced this pull request Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit that referenced this pull request Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Changed the ODBC build platform to MacOS 10.15 from latest - #229
Closed
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Closed
Changed the ODBC build platform to MacOS 10.15 from latest#229
chloe-zh wants to merge 13 commits into
opensearch-project:mainfrom 
chloe-zh:issue/odbc-1005
Conversation
@chloe-zh
@chloe-zhchloe-zh
commented
Oct 8, 2021

Copy link


Copy Markdown

Contributor
Description
The ODBC build fails but the build on macos 10.15 and earlier is working fine.
Issues Resolved
N/A
Check List
  •  New functionality includes testing.

    •  All tests pass, including unit test, integration test and doctest
  •  New functionality has been documented.

    •  New functionality has javadoc added
    •  New functionality has user manual doc added
  •  Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@chloe-zh
Added span in ppl; push down only
ad60d37
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
refined span return type
9036be4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
807d1f3
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
implemented in memory execution of span aggregation
96d0e41
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
checkstyle
542562a
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
enabled alias
b7674a6
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added integration test
46b94c4
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
190edec
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
update
968643d
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
added unit test cases for span aggregation builder and parser
fa0aec0
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Updated PPL user manual
d16da88
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
Specified the odbc build platform to MacOS 11 instead of latest to av…
03cbaff
…oid the compatibility issue
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh
macos-10.15
bee0bc8
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zhchloe-zh
closed this
Oct 8, 2021
dblock
dblock
reviewed
Oct 13, 2021
View reviewed changes
Comment thread.github/workflows/sql-odbc-release-workflow.yml
jobs:
 build-mac:
 runs-on: macos-latest
 runs-on: macos-11
@dblockdblockOct 13, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally different from build?
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 5, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#226)
e951192
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Yury-Fridlyand added a commit
that referenced
this pull request
Apr 27, 2023
@Yury-FridlyandMaxKsyunz
@GabeFernandez310@MaxKsyunz
Support pagination in V2 engine, phase 1 (#1497)
f40bb6d
* Support pagination in V2 engine, phase 1 (#226)
* Fixing integration tests broken during POC
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Comment to clarify an exception.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for paginated scroll request, first page.
Implement PaginatedPlanCache.convertToPlan for second page to work.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Progress on paginated scroll request, subsequent page.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Move `ExpressionSerializer` from `opensearch` to `core`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename `Cursor` `asString` to `toString`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Disable scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add full cursor serialization and deserialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Misc fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Further work on pagination.
* Added push down page size from `LogicalPaginate` to `LogicalRelation`.
* Improved cursor encoding and decoding.
* Added cursor compression.
* Fixed issuing `SearchScrollRequest`.
* Fixed returning last empty page.
* Minor code grooming/commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination fix for empty indices.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix error reporting on wrong cursor.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor comments and error reporting improvement.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add an end-to-end integration test.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add `explain` request handlers.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add IT for explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address issues flagged by checkstyle build step (#229)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Pagination, phase 1: Add unit tests for `:core` module with coverage. (#230)
* Add unit tests for `:core` module with coverage. Uncovered: `toCursor`, because it is will be changed soon.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Pagination, phase 1: Add unit tests for SQL module with coverage. (#239)
* Add unit tests for SQL module with coverage.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update sql/src/main/java/org/opensearch/sql/sql/domain/SQLQueryRequest.java
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
* Pagination, phase 1: Add unit tests for `:opensearch` module with coverage. (#233)
* Add UT for `:opensearch` module with full coverage, except `toCursor`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix checkstyle.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix the merges.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix explain.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Store `TotalHits` and use it to report `total` in response.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing UT for `:protocol` module.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix PPL UTs damaged in f4ea4ad.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor checkstyle fixes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fallback to v1 engine for pagination (#245)
* Pagination fallback integration tests.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add UT with coverage for `toCursor` serialization.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix broken tests in `legacy`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix getting `total` from non-paged requests and from queries without `FROM` clause.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix scroll cleaning.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix cursor request processing.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update ITs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix (again) TotalHits feature.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix typo in prometheus config.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Recover commented logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move `test_pagination_blackbox` to a separate class and add logging.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address some PR feedbacks: rename some classes and revert unnecessary whitespace changed.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor commenting.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Address PR comments.
* Add javadocs
* Renames
* Cleaning up some comments
* Remove unused code
* Speed up IT
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor missing changes.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Integration tests for fetch_size, max_result_window, and query.size_limit (#248)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedQueryService`, extend `QueryService` to hold two planners and use them.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Move push down functions from request builders to a new interface.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Some file moves.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor clean-up according to PR review.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
* Make scroll timeout configurable.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Fix IT to set cursor keep alive parameter.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove `QueryId.None`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Rename according to PR feedback.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations of `PushDownRequestBuilder`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Merge paginated plan optimizer into the regular optimizer. (#1516)
Merge paginated plan optimizer into the regular optimizer.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Complete rework on serialization and deserialization. (#1498)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Resolve merge conflicts and fix tests.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Minor cleanup - missing changes for the previous commit.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove paginate operator (#1528)
* Remove PaginateOperator class since it is no longer used.
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Remove `PaginatedPlan` - move logic to `QueryPlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Remove default implementations from `SerializablePlan`.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add a doc.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Update design graphs.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* More fixes for merge from upstream/main.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
---------
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@dblockdblockdblock left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@chloe-zh@dblock